Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geb HVAC - Onoff thermostat and realistic staging #1639

Draft
wants to merge 299 commits into
base: master
Choose a base branch
from

Conversation

yzhou601
Copy link
Collaborator

@yzhou601 yzhou601 commented Mar 4, 2024

Pull Request Description

Single Speed System features:

  1. On-off Deadband thermostat
  2. Start-up Loss

Two Speed System features:

  1. On-off Deadband thermostat
  2. Realistic Staging

Integrated backup coil features:

  1. Capacity increment and realistic staging (similar to two speed systems)

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

yzhou601 and others added 30 commits May 21, 2021 19:19
@yzhou601 yzhou601 changed the title Allow Multi-stage Electric Backup Coil Geb HVAC - Onoff thermostat and realistic staging Apr 25, 2024
@yzhou601
Copy link
Collaborator Author

yzhou601 commented Apr 25, 2024

Action items:

  • Resolve the backup actuator conflicts across different features
  • Add test files with multiple geb features
  • Fix EnergyPlus bug for multi-stage backup coil
  • Add issue to switch actuator once EnergyPlus bug is fixed

@yzhou601 yzhou601 changed the base branch from master to defrost_improvements May 17, 2024 02:37
Base automatically changed from defrost_improvements to master May 18, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

None yet

3 participants