Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Geb HVAC - Single Speed and Two Speed Systems #744

Closed
wants to merge 261 commits into from
Closed

Geb HVAC - Single Speed and Two Speed Systems #744

wants to merge 261 commits into from

Conversation

yzhou601
Copy link
Collaborator

@yzhou601 yzhou601 commented Apr 29, 2021 •
edited by shorowit

Pull Request Description

Single Speed features:

  1. On-off Deadband thermostat
  2. Start-up Loss

Two Speed features:

  1. On-off Deadband thermostat
  2. Realistic Staging

Alternative of #458

Checklist

Not all may apply:

  • EPvalidator.xml has been updated
  • Tests (and test files) have been updated
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected regression test changes on CI (checked comparison artifacts)

yzhou601 and others added 29 commits October 21, 2020 18:46
@yzhou601
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
1816115 
…o geb-hvac
@yzhou601
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
d4254b7 
…o geb-hvac

# Conflicts:
#	HPXMLtoOpenStudio/resources/hvac.rb
@yzhou601
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
ce252a9 
…o geb-hvac
@yzhou601
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
e014df7 
…o geb-hvac
@yzhou601
Implemented Jon's curve, set timestep requirement to enable onoff con…
ca402ed 
…trol
@yzhou601
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
6ed37a1 
…o geb-hvac
@yzhou601
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
318328a 
…o geb-hvac
@yzhou601
use curve value at middle of timestep, add warning.
024ff8a
@yzhou601
some progress..
c1ce633
@yzhou601
progress
1291fa0
@yzhou601
Merge branch 'master', resolved conflicts and restructured a bit
0e70d6c
@yzhou601
update test files and bugfixes
3cd57df
@yzhou601
implement EMS program, bugfix
7f2b03a
@yzhou601
format, revert measure.xml
c3f6e69
@yzhou601
bugfix
d791dd0
@yzhou601
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
6c19913 
…o geb-hvac

# Conflicts:
#	HPXMLtoOpenStudio/measure.xml
@yzhou601
bugfix
7c7309a
@yzhou601
fix a bug in rated air flow rates and defrost defaults, cleanup metho…
88a77db 
…d arguments
@yzhou601
handle duct program when there're two fans
b928d25
@yzhou601
bugfix for duct
0c71b58
@yzhou601
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
d8d19dc 
…o geb-hvac
@yzhou601
oops
48dae80
@yzhou601
revert exclude new test
2f4a21b
@yzhou601
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
9d65e72 
…o geb-hvac
@yzhou601
update test files
25df61d
@yzhou601
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
0c03da5 
…o geb-hvac
@yzhou601
remove changes in hvac.rb for two speed systems
b06a489
@yzhou601
progress
0f120bb
@yzhou601
Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML int…
33d6caf 
…o geb-hvac-2

# Conflicts:
#	SimulationOutputReport/measure.xml
@yzhou601 yzhou601 self-assigned this Apr 29, 2021
@yzhou601 yzhou601 changed the title Geb HVAC - Two Speed Realistic Cycling Geb HVAC - Single Speed and Two Speed Systems Mar 12, 2024
yzhou601
yzhou601 commented Apr 4, 2024
View reviewed changes
workflow/sample_files/base-hvac-realistic-control-2-speed-central-ac.xml Outdated
<extension>
<SimulationControl>
<Timestep>1</Timestep>
<TemperatureCapacitanceMultiplier>4.0</TemperatureCapacitanceMultiplier>
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update this to 7

@yzhou601 yzhou601 requested a review from shorowit April 4, 2024 21:08
shorowit
shorowit reviewed Apr 4, 2024
View reviewed changes
Changelog.md Outdated
Comment on lines 182 to 183
- **Research Feature**: Allows modeling on/off thermostat deadband with start-up degradation for single speed central ac and single speed ashp systems. Currently only supports homes with at most one cooling system serving 100% cooling loads, and one heating system serving 100% heating loads (including heat pumps). An on/off thermostat deadband temperature is a temperature difference between cut-in and cut-out temperature for HVAC operations, applied to both heating and cooling.
- **Research Feature**: Allows modeling time-based realistic staging for two speed DX systems (central ac and ASHP). Assumes 5 minutes before transitioning to a higher speed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be moved up to OS-HPXML v1.8. Also, we should make these notes consistent with the variable-speed GEB item. And I would shorten the descriptions -- if any of the detail is important, it should be in the documentation, not the changelog.

workflow/tests/base_results/results_hvac_sizing.csv Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should be deleted.

@shorowit
Copy link
Contributor

Discussion notes:

  1. Create new /HPXML/Building/BuildingDetails/BuildingSummary/extension/HVACGEBControl element with UseRealisticCyclingModel and a HP backup capacity increment input.
  2. Combine this PR with the HP backup staging PR.
  3. Add Research Feature to these features and existing ones (variable-speed capacity ratios, HPWH operating mode schedule, conventional storage WH tank type, temperature capacitance multiplier (TCM), etc.) in the documentation.
  4. Make sure we give a warning if TCM is 1 when used with some of these features.

@yzhou601
Copy link
Collaborator Author

This is combined into #1639

@yzhou601 yzhou601 closed this Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shorowit shorowit shorowit left review comments

Assignees

@jmaguire1 jmaguire1

@yzhou601 yzhou601

Labels
energyplus enhancement New feature or request
Projects
OpenStudio-HPXML
Archived in project
OpenStudio-HPXML
In progress
Milestone
1.8.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yzhou601 @shorowit @jmaguire1