Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle root files listed in project config from referenced project to be same as if they were included through import #58560

Merged
merged 4 commits into from
May 20, 2024
Merged

Handle root files listed in project config from referenced project to be same as if they were included through import #58560

merged 4 commits into from
May 20, 2024

Conversation

sheetalkamat
Copy link
Member

@sheetalkamat sheetalkamat commented May 17, 2024 •
edited

  • Always look if file looking is redirect to output of referenced project
  • In buildInfo store if root file is not same as resolved path so tsc --b can use it to determine correct checks on input hash

Fixes #58156

@typescript-bot typescript-bot added Author: Team For Milestone Bug PRs that fix a bug with a specific milestone labels May 17, 2024
@sheetalkamat sheetalkamat mentioned this pull request May 17, 2024
Merged
jakebailey
jakebailey approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@jakebailey jakebailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm less familiar with this but so take my review with a grain of salt 😅

src/compiler/builder.ts Outdated Show resolved Hide resolved
@sheetalkamat sheetalkamat merged commit d84431e into main May 20, 2024
28 checks passed
@sheetalkamat sheetalkamat deleted the rootFiles branch May 20, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakebailey jakebailey jakebailey approved these changes

@andrewbranch andrewbranch Awaiting requested review from andrewbranch

@RyanCavanaugh RyanCavanaugh Awaiting requested review from RyanCavanaugh

Assignees

@sheetalkamat sheetalkamat

Labels
Author: Team For Milestone Bug PRs that fix a bug with a specific milestone
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upstream file not correctly recognized as output of other project when using path mappings
3 participants
@sheetalkamat @jakebailey @typescript-bot