Handle project / program roots in tsserver correctly #58562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Milestone Bug
|
Looks like you're introducing a change to the public API surface area. If this includes breaking changes, please document them on our wiki's API Breaking Changes page. Also, please make sure @DanielRosenwasser and @RyanCavanaugh are aware of the changes, just as a heads up. |
sheetalkamat
force-pushed
the
semanticHighlighting
branch
from
409efc4
to
c1fc93d
Compare
sheetalkamat
requested review from
andrewbranch and
jakebailey
and removed request for
andrewbranch
jakebailey
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if file is from "d.ts" or ".ts" of the referenced project as root of the project but the project includes exact opposite of that (input or output respectively) then we have issues with where we incorrectly assume these root names to be part of project . It is obviously incorrect and that results in getting incorrect default project for the file and uses incorrect sourceFIle for the actual file name and incorrect results. Eg in the repro instead of getting results from "index.d.ts" it is gettting results from "index.ts" as it assumes its the same file.
With this fix we always ensure our
rootFilesMapis holding correct scriptInfo and hence correct default project for output or input of referenced project file.This fixes this issue.
Fixes #56254