Fix issue with llvm-rc when ZYDIS_BUILD_SHARED_LIB is enabled
#500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flobernd
reviewed
Apr 7, 2024
I changed it already here as well. Sorry, GitHub doesn't do a great job of showing this due to the encoding change, maybe I should have clarified! |
|
@netadr Oh, my bad. I even clicked on "view file", but GitHub seems to show me the old version. Do you want to update the zycore-c submodule in this PR? We can do this in a later step as well, if that's more comfortable for you. |
@flobernd Should be fixed now! |
OptionalAssistant
pushed a commit
to OptionalAssistant/zydis
that referenced
this pull request
Apr 17, 2024
…antific#500) * Fix issue with `llvm-rc` when `ZYDIS_BUILD_SHARED_LIB` is enabled * Bump zycore submodule
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to the changes mentioned in zyantific/zycore-c#70, this changes the encoding of
resources/VersionInfo.rcfrom UTF-16LE to UTF-8 asclang's preprocessor does not support UTF-16.