Prepare v4.1 release #484
Merged
Prepare v4.1 release #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zydis currently requests a C++ compiler despite not actually using it. This breaks build on toolchains without a C++ compiler (e.g. musl libc). @Tachi107 already did the same for zycore a while ago: zyantific/zycore-c@8f39333
* Update zycore submodule * Use ZYAN_DIV64 in ZydisStringAppendDecU64 Avoid a direct 64bit integer division in ZydisStringAppendDecU64 and use the macro provided by zycore instead, as GCC might generate unwanted calls to arithmetic functions on 32bit platforms.
Fix some warnings output by GCC when compiling amalgamated source
Make decoder_mode a bitmap instead of an array of booleans for space efficiency.
The previous code would mix up absolute and relative paths to determine when to print the warning about public headers first being encountered when processing the source files. This commit fixes this and thus gets rid of the incorrect warnings.
Multiple functions without arguments were missing the `(void)` that prevents them from being interpreted as not having a prototype. Newer Clang versions started printing warnings for that in pedantic mode.
This commit reworks large parts of our primary README. - Add a list prominent Zydis users - Explain how to do no-libc builds - Remove links to unmaintained bindings - Remove badge that links to the dead gitter channel - Revamp the build instructions - Mention the various package managers that ship Zydis - Explain the amalgamated distribution - Various other smaller improvements
This should allow Zydis to find Zycore in more situations automatically. Most importantly, `find_package(Zycore)` is now something that we try automatically. This should allow distributions that ship Zycore as a separate package to do so more easily without having to delve into out CMake logic to discover the `ZYAN_SYSTEM_ZYCORE` option.
We previously went with explicitly adding `@file` directives to our headers instead of using `EXTRACT_ALL` because the latter was broken with the m.css theme that we were using previously. m.css has a custom code generator that didn't support the directive. We've since switched to another theme that just re-styles the vanilla HTML, so we're fine to just use that now (instead of changing the code-gen to add the directives in all generated headers).
According to the documentation glob returns files in arbitrary order. Let's sort paths to keep the same order of files for amalgamation. Signed-off-by: Denis Efremov <denis.e.efremov@oracle.com>
This reverts the interface-breaking portion of 6ab4463.
This reverts commit 04c092c.
flobernd
approved these changes
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
maintenance/v4branch1 by rebasing all changes from master on top of it and then reverting the breaking changes. Please review the last few commits for the (partial) reverts and version bumps.Blocked on zyantific/zycore-c#69.
Once this PR is merged, I'll create a tag and a corresponding release.
Footnotes
This didn't exist previously: I just branched this off from
v4.0.0tag and published it. ↩