Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alignment issues with Intel macOS builds #475

Merged
merged 1 commit into from
Jan 16, 2024
Merged

Conversation

athre0z
Copy link
Member

@athre0z athre0z commented Jan 16, 2024

Resolves #474

@JamesAldridge can you please verify that this resolves the issue? I also updated the condition for popping the alignment again below, which I'm not sure whether you tested as well.

@athre0z athre0z added C-bug Category: This is a bug (or a fix for a bug, when applied to PRs) P-medium Priority: Medium A-build Area: Build system labels Jan 16, 2024
@athre0z athre0z requested a review from flobernd January 16, 2024 17:41
Copy link

@JamesAldridge JamesAldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I changed the pop as well. It's good to go

Copy link
Member

@flobernd flobernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@athre0z athre0z merged commit a605f54 into master Jan 16, 2024
13 checks passed
@athre0z athre0z deleted the fix-macos-intel-build branch January 16, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-build Area: Build system C-bug Category: This is a bug (or a fix for a bug, when applied to PRs) P-medium Priority: Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failed: build zydis as a dynamic link library on MacOS
3 participants