Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve fuzzer stability in persistent mode #453

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Conversation

athre0z
Copy link
Member

@athre0z athre0z commented Sep 13, 2023

fread does internal buffering that can result in different code paths to be taken every time we call it. This is detrimental for fuzzing stability in persistent mode. This PR changes the code to use a direct read syscall on POSIX.

@athre0z athre0z added C-enhancement Category: Enhancement of existing features A-fuzzing Area: Fuzzing tools / OSS-fuzz labels Sep 13, 2023
@athre0z athre0z self-assigned this Sep 13, 2023
Copy link
Member

@flobernd flobernd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@athre0z athre0z merged commit 460570f into master Sep 14, 2023
13 checks passed
@athre0z athre0z deleted the fuzzing-stability branch September 14, 2023 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-fuzzing Area: Fuzzing tools / OSS-fuzz C-enhancement Category: Enhancement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants