Add link laucher #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ABausG
suggested changes
Apr 22, 2022
Co-authored-by: Anton Borries <anton.borries@2denker.de>
|
Also realised that you should increase the version and add something to the changelog |
Adopted the Test to use Mockito for Mocking Also added option to open Link Externally that always uses url_launcher fixed deprecation and imports
|
@soeren-schmaljohann-2denker I cleaned up the test by using mocktail (wrong in the commit message) |
|
I also added a block to ignore the coverage for the else branch in the link launcher as that would require gskinnerTeam/flutter-universal-platform#15 to be solved first |
|
so, is this mergable? |
ABausG
approved these changes
May 4, 2022
|
Yes could be merged. By the way: On github you can re-request review by hitting the 🔄 icon next to the reviewer |
good to know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.