fix(config): correct config parameters for Minoston MP21ZD Dimmer Plug #6686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rymarczy
commented
Feb 22, 2024
| } | ||
| ], | ||
| "metadata": { | ||
| "inclusion": "1. Refer to your primary controller instructions to process the inclusion / exclusion setup procedure.\n2. When prompted by your primary controller, click the button three times in one second", | ||
| "exclusion": "1. Refer to your primary controller instructions to process the inclusion / exclusion setup procedure.\n2. When prompted by your primary controller, click the button three times in one second", | ||
| "reset": "Press click Z-Wave button 3 times quickly, and hold for at least 10 seconds at the third time to restore the device to the factory\n(Node:Please use this procedure only when the network primary controller is missing or otherwise inoperable.)", | ||
| "manual": "https://products.z-wavealliance.org/ProductManual/File?folder=&filename=product_documents/4137/MP21ZD%20Manual-20210322.pdf" |
There was a problem hiding this comment.
This link opens a manual for the Minoston MP21ZS, not a MP21ZD
There was a problem hiding this comment.
Minoston offers a 700 and 800 series version of this plug, but both versions have the same parameter set reflected by this PR.
|
I have nightmares from the mess around those Minoston devices. Will have to look at this in depth before a review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing configuration parameters for the MP21ZD were pulled from a similar, but different, Minoston dimmer plug and are mostly incorrect.
This PR corrects the configuration parameters for the MP21ZD, based on the parameters available in the user manual from Minoston: https://cdn-files.myshopline.com/file/store/1701829637050/MP21ZD(800-Series)-Manual.pdf
This required a few additions to the template config, for new parameters that appear to not have any prior work in existing template files.
I believe I followed all the style guide rules, to the best of my ability, but always open for feedback.
Thanks!