feat(config): modify ZEN30 to match Zooz change log #6630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Had to assume minimum level for this device was 1.5 (I'm assuming that 1.05 gets read as 1.5 per normal convention) The current file seemed to make that assumption too as param 22 was missing, 24, 25. and 26 were already added. I did not understand some of the "If" firmware statements, so changed them to how I understand it. Quite a mess of firmware revisions. Params 28, 29 and 30 were added for 1.11, missing from 2.0, added back in 2.11, dropped for 3.0 and finally added for good in 3.10. Anyway take a look if you have anytime for configs. Signed-off-by: Bob Eckhoff <katmandodo@yahoo.com>
Signed-off-by: Bob Eckhoff <katmandodo@yahoo.com>
Signed-off-by: Bob Eckhoff <katmandodo@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description here;
Had to assume minimum level for this device was 1.5 (I'm assuming that 1.05 gets read as 1.5 per normal convention) The current file seemed to make that assumption too as param 22 was missing, 24, 25. and 26 were already added. I did not understand some of the "If" firmware statements, so changed them to how I understand it.
Quite a mess of firmware revisions. Params 28, 29 and 30 were added for 1.11, missing from 2.0, added back in 2.11, dropped for 3.0 and finally added for good in 3.10. It should be close, so take a look if you have anytime for device configs.
Would close #6624