fix(config): support Comet parameters properly #6583
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR fixes / enhances the Eurotronic Comet Z-Wave in various ways.
1. Manufacturer specific mode (1st commit)
I have Eurotronic CometZ-Wave devices, which report like this :
https://pastebin.com/raw/zbF6cpfY
As for the Eurotronic Spirit devices, the Manufacturer mode is supported / documented, but not reported by the device.
Interestingly enough is the Full power mode, reported by the device, but not documented by Eurotronic.
Device's firmware may have been updated since the documentation...
Let's then apply the same modification as for the Spirit device :
https://github.com/zwave-js/node-zwave-js/blob/master/packages/config/config/devices/0x0148/spirit.json
Result :
Note that when enabling the Manufacturer specific mode in Home Assistant through its default / builtin thermostat, it works, but also reports the following warning :
Failed to call service climate/set_hvac_mode. expected HVACMode or one of 'off', 'heat', 'cool', 'heat_cool', 'auto', 'dry', 'fan_only' for dictionary value @ data['hvac_mode']
When setting the Manufacturer specific mode manually (through Home Assistant Developer Tools / zwave_js.set_value), the warning does not trigger. Should then be related to the default / builtin thermostat itself.
2. Supervision (2nd commit)
There's a report here indicating that parameters can't be set.
As found on other devices, seems like Comet device does not like supervision. Let's then disable it.
It then fixes home-assistant/core#103254.
Should a report be made to Eurotronic about supervision ?
3. Valve opening (3rd commit)
Some devices report valve opening parameter, some don't, may be related to firmware version (or to template used, I'm not sure here...).
But even when not initially reported by the device, it is supported.
Let's then enable this useful option.
Result (enabled after 6:00) :
Thank you very much 👍