feat(config): parameter update for Zooz Zen16 v2.0 #6569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeOriginal
changed the title
CodeOriginal
changed the title
AlCalzone
requested changes
Apr 2, 2024
| @@ -909,6 +909,78 @@ | |||
| { | |||
| "label": "Garage door (momentary mode for Z-Wave control)", | |||
| "value": 3 | |||
| }, | |||
There was a problem hiding this comment.
This should be a new template, since those input types are only available in revision 2 (firmware 2.0+) of the switch.
| @@ -74,6 +74,13 @@ | |||
| "$import": "templates/zooz_template.json#zen16_switch_type_v2", | |||
| "label": "Switch 1: Type" | |||
| }, | |||
| { | |||
| "#": "25", | |||
| "$if": "firmwareVersion >= 1.2", | |||
There was a problem hiding this comment.
Suggested change
| "$if": "firmwareVersion >= 1.2", | |
| "$if": "firmwareVersion >= 2.0", |
Same for the other new parameters.
| "$if": "firmwareVersion >= 1.2", | ||
| "$import": "templates/zooz_template.json#zen16_switch_invert_v2", | ||
| "label": "Switch 1: Invert Value", | ||
| "description": "Invert the reported values for your selected switch type in Sw1 terminals (select the same value as you chose for parameter 2 to invert the values for open and closed circuit)." |
There was a problem hiding this comment.
We try to keep descriptions as short as possible and avoid repeating the label in other words. Only use this if necessary to add additional information, e.g.
Suggested change
| "description": "Invert the reported values for your selected switch type in Sw1 terminals (select the same value as you chose for parameter 2 to invert the values for open and closed circuit)." | |
| "description": "Select the same value as in parameter 2 to invert the values for open and closed circuit." |
Same for params 26/27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds parameters available to the Zooz Zen16 v2.0 from Zooz's Documentation relating to the switch inputs which are missing from the current config files.