feat(config): added yale fingerprint series

[catduckgnaf]

Feat(config): Added YRD410-F-ZW3, YRD420-F-ZW3, YRD430-F-ZW3 & YRD450-F-ZW3

YRD410-F-ZW3 Assure 2 Lock Touch SL Keyed Pushbutton Deadbolt ID 0x4936
YRD420-F-ZW3 Assure 2 Lock Touch SL Keyed Touchscreen Deadbolt ID(s) 0x4929
YRD430-F-ZW3 Assure 2 Lock Touch SL Key Free Pushbutton Deadbolt ID 0x4934
YRD450-F-ZW3 Assure 2 Lock Touch SL Key Free Touchscreen Deadbolt ID(s) 0x4913, 0x4928

[apella12]

No comment as to content, but I believe your title should be feat(config): added ... if you want to clear the error.

[catduckgnaf]

No comment as to content, but I believe your title should be feat(config): added ... if you want to clear the error.

thanks, think i got it now

[catduckgnaf]

Did I get the title right or do I need to do anything else?

[apella12]

I'm not the reviewer/approver. I just thought clearing the error would get more attention from the reviewer. My observation is he/they are pretty busy. Have you added these files to the store/config folder and reinterview ? I think will get them working locally (but not entirely sure).

[catduckgnaf]

You are right. I know they are. I also have discovered a missing device id. Im gonna close and look. It works locally.

[apella12]

Again a tip, but no review. Take a quick look at the details of the failing tests for clues. There is an extra ], on line 11 of one file. There may be more, but that's one. I don't know how you code, but I use VSC and there is some checking built into the node-js repository. (still make mistakes though..)

[catduckgnaf]

Thank you, looks good. I appreciate you correcting that.