-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compose: Move row of formatting buttons into the textbox. #29953
Open
N-Shar-ma
wants to merge
1
commit into
zulip:main
Choose a base branch
from
N-Shar-ma:btns-in-textbox
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+70
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zulipbot
added
size: S
area: compose (UI & widgets)
Scheduled messages, giphy, send later, etc.
redesign
Part of the webapp redesign project, including blockers.
labels
May 4, 2024
Hello @zulip/design members, this pull request was labeled with the "redesign" label, so you may want to check it out! |
N-Shar-ma
force-pushed
the
btns-in-textbox
branch
from
May 14, 2024 08:39
8223f04
to
267e95e
Compare
N-Shar-ma
force-pushed
the
btns-in-textbox
branch
2 times, most recently
from
May 18, 2024 08:33
cc66ddd
to
5a68023
Compare
N-Shar-ma
force-pushed
the
btns-in-textbox
branch
3 times, most recently
from
May 20, 2024 06:24
0f4be6d
to
2c4c700
Compare
N-Shar-ma
force-pushed
the
btns-in-textbox
branch
from
May 21, 2024 07:24
2c4c700
to
20d04b4
Compare
@alya Thanks for the feedback!
|
N-Shar-ma
force-pushed
the
btns-in-textbox
branch
from
May 22, 2024 06:48
20d04b4
to
78ea4ee
Compare
12 tasks
N-Shar-ma
force-pushed
the
btns-in-textbox
branch
from
May 23, 2024 08:53
78ea4ee
to
9689892
Compare
The row of buttons is placed using CSS grid template areas so that visually it is now inside the bottom edge of the textbox. The color of the buttons row and individual buttons is changed to match the color of the textbox. All textbox border / box shadow properties are now applied to its parent instead which is extended under the buttons' row, so that its border snuggly fits around the buttons row too. Notable side effects: - In dark mode the textbox in focused state now has a light border which does not match the recipient input's current border which doesn't change when focused. Likely, the recipient input should be updated to match the textbox's border color. - The dividers in the formatting buttons row are not vertically centered now. This should be figured out soon. Known concern: - The textbox resize handle still shows, breaking the illusion of the buttons row being inside the textbox. It will be removed when enabling a 3 stage resizeable textbox. Fixes: zulip#28702.
N-Shar-ma
force-pushed
the
btns-in-textbox
branch
from
May 23, 2024 09:24
9689892
to
5615cfd
Compare
@alya The tabbing order has been fixed! All feedback so far has now been addressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: compose (UI & widgets)
Scheduled messages, giphy, send later, etc.
redesign
Part of the webapp redesign project, including blockers.
size: XL
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The row of buttons is placed using CSS grid template areas so that visually it is now inside the bottom edge of the textbox. The color of the buttons row and individual buttons is changed to match the color of the textbox. All textbox border / box shadow properties are now applied to its parent instead which is extended under the buttons' row, so that its border snuggly fits around the buttons row too.
Notable side effects:
Known concern:
Fixes: #28702.
Screenshots and screen captures:
Light Mode
Hovering a button:
Focus in textbox:
Preview mode:
Dark Mode
Hovering a button:
Focus in textbox:
Preview mode:
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: