hashchange: Select the new near id if it is already rendered. #29875
+33
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If in the same narrow, we just want to select a new id which is already rendered, we don't need to call `narrow.activate`, we can just select the new id.
timabbott
reviewed
Apr 27, 2024
| // Remove elements from hash that don't effect the narrow. | ||
| // TODO: Expand the regex to include more items we can ignore. | ||
| hash1 = hash1.replace(/near\/\d+$/, ""); | ||
| hash2 = hash2.replace(/near\/\d+$/, ""); |
There was a problem hiding this comment.
This should be calculated using the filter.ts module helpers -- regexs will always be inaccurate, but we can check that they have the same set of sorted operators and operands, with perhaps the exception of a near operator in one or the other.
timabbott
reviewed
Apr 27, 2024
| // Just select the message if the narrow is the same as the current narrow and | ||
| // we already have the new message we want to select rendered. | ||
| // TODO: Implement a filter comparison function so that we do it for any two narrows | ||
| // when calling narrow.activate. |
There was a problem hiding this comment.
Yeah I agree with the thought that we should be doing this in narrow.activate if possible, so that if we add some helper click handler it still works as designed.
timabbott
reviewed
Apr 27, 2024
| if (filter.has_operator("near")) { | ||
| const target_id = Number.parseInt(filter.operands("near")[0], 10); | ||
| if (message_lists.current.get(target_id)) { | ||
| message_lists.current.select_id(target_id, {then_scroll: true}); |
There was a problem hiding this comment.
I guess if the narrow.activate call had a then_select_offset calculated, we might want to additionally scroll to that offset?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If in the same narrow, we just want to select a new id which is already rendered, we don't need to call
narrow.activate, we can just select the new id.