dialog_widget: Check if modal is open before closing. #29874
+8
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug where marking messages read in recent view logs warning in console that we are trying to close a modal when none is open.
amanagr
force-pushed
the
close_active_war
branch
from
0a6f4c3
to
91e298b
Compare
timabbott
reviewed
Apr 27, 2024
|
|
||
| if (dialog_widget.is_open()) { | ||
| dialog_widget.close(); | ||
| } |
There was a problem hiding this comment.
Hmm, it might be better if we can have the callers pass the specific dialog that initiated this request? Given that this is happening after a network delay, the user might be using some totally different dialog by the time we get here.
Also, notably, is it intended that this happens even on recursive calls?
|
Heads up @amanagr, we just merged some commits that conflict with the changes you made in this pull request! You can review this repository's recent commits to see where the conflicts occur. Please rebase your feature branch against the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
discussion: https://chat.zulip.org/#narrow/stream/9-issues/topic/close_active.28.29.20called.20without.20checking.20any_active.28.29