Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fenced_code.py: Implement error logging for hiliter. #29868

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lemmasamaha
Copy link
Collaborator

Instead of returning error 400 when pygment library fails to parse we log the error and keep going

Fixes #22287

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

Instead of returning error 400 when pygment library fails to parse
we log the error and keep going

Fixes zulip#22287
@zulipbot
Copy link
Member

Hello @zulip/server-markdown members, this pull request was labeled with the "area: markdown" label, so you may want to check it out!

@alya
Copy link
Contributor

alya commented Apr 27, 2024

@alexmv are you the right person to review this one?

@alya alya added the maintainer review PR is ready for review by Zulip maintainers. label Apr 27, 2024
@timabbott
Copy link
Sponsor Member

@lemmasamaha can you post sample logging output from when this is triggered?

It would also be great to add a test, as mentioned in the issue.

@timabbott timabbott added the completion candidate PRs with reviews that may unblock merging label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: markdown completion candidate PRs with reviews that may unblock merging maintainer review PR is ready for review by Zulip maintainers. size: S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failures in pygments rendering should not 400 a message post
5 participants