Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

portico: Change CTA buttons in the top section of /hello. #29848

Merged
merged 2 commits into from Apr 29, 2024

Conversation

alya
Copy link
Contributor

@alya alya commented Apr 25, 2024

Link to new demo request form instead of communities directory.

Before: https://zulip.com/

After:
Screenshot 2024-04-25 at 14 01 11
Screenshot 2024-04-25 at 14 01 06

@alya alya added the integration review Added by maintainers when a PR may be ready for integration. label Apr 25, 2024
@timabbott
Copy link
Sponsor Member

@amanagr can you fix the test failures on this? The value of for is supposed to be an ID, rather than a name, in a form.

(And by linking to the page, this PR makes our crawler notice that). Possibly the other support form has the same bug.

alya and others added 2 commits April 29, 2024 05:52
Link to new demo request form instead of communities directory.
Add title and set label and id of input same for a field.
@zulipbot zulipbot added size: M and removed size: S labels Apr 29, 2024
@timabbott timabbott merged commit 9184e6c into zulip:main Apr 29, 2024
7 checks passed
@timabbott
Copy link
Sponsor Member

Merged, thanks @alya and @amanagr!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration review Added by maintainers when a PR may be ready for integration. size: M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants