Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

help: Update documentation on switching themes. #29840

Merged
merged 1 commit into from May 2, 2024

Conversation

sayamsamal
Copy link
Collaborator

@sayamsamal sayamsamal commented Apr 25, 2024

As a follow-up to commit ad013a9, this updates the /help/dark-theme docs to describe the newer way to switch themes via the theme switcher, located in the Personal Menu.

This replaces the documentation on switching themes via "Personal Settings".

Fixes: #29550.

Screenshots and screen captures:

Before After
image image
Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@zulipbot
Copy link
Member

Hello @zulip/server-user-docs members, this pull request was labeled with the "area: documentation (user)" label, so you may want to check it out!

@sayamsamal
Copy link
Collaborator Author

@alya Does the updated documentation read well to you? The last point might be a bit on the lengthier side, and need splitting? I don't have much idea about it, so waiting for your feedback.

@alya
Copy link
Contributor

alya commented Apr 30, 2024

Thanks! Our pattern is not to list out the options; I'll add a note about that here.

help/dark-theme.md Outdated Show resolved Hide resolved
@alya
Copy link
Contributor

alya commented Apr 30, 2024

Thanks! Our pattern is not to list out the options; I'll add a note about that here.

#29906

As a follow up to commit ad013a9, this updates the /help/dark-theme
docs to describe the newer way to switch themes via the theme switcher,
located in the Personal Menu.

This replaces the documentation on switching themes via
"Personal Settings".

Fixes zulip#29550.
@sayamsamal sayamsamal force-pushed the update-theme-switching-docs branch from 55718e1 to 0e94983 Compare May 2, 2024 03:59
@sayamsamal
Copy link
Collaborator Author

@alya ready for another review.

@timabbott timabbott merged commit 8fb7ab8 into zulip:main May 2, 2024
7 checks passed
@timabbott
Copy link
Sponsor Member

Merged, thanks @sayamsamal!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update documentation on switching themes
4 participants