Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

message_view_header: Add description to views in top-navbar. #29818

Closed
wants to merge 1 commit into from

Conversation

Mahhheshh
Copy link
Contributor

fixes: #29769

  • Add Help Center Link.

Screenshots and screen captures:

Inbox

image

Recent Conversactions

image

Combined Feed

image

Mentions

image

Starred messages

image

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

@zulipbot
Copy link
Member

Hello @zulip/server-onboarding members, this pull request was labeled with the "area: onboarding" label, so you may want to check it out!

@@ -1736,7 +1736,6 @@ div.focused-message-list {
default that would otherwise run titles under the search box. */
.navbar_title,
.narrow_description {
flex: 1 1 0;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed because of the;
image

@alya
Copy link
Contributor

alya commented Apr 23, 2024

I'm not sure why we have 2 PRs for this issue, but please seem #29824 and my comments on it, in case they are relevant.

@Mahhheshh Mahhheshh closed this Apr 24, 2024
@Mahhheshh Mahhheshh deleted the view-description branch May 2, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Describe views in top navbar
3 participants