Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left/Right Arrow Keys Navigation #29508

Closed
wants to merge 4 commits into from
Closed

Left/Right Arrow Keys Navigation #29508

wants to merge 4 commits into from

Conversation

rs545837
Copy link
Collaborator

The issue for the left navigation from the help menu to the userlist toggle button is working with this PR. Although there is still an issue on using the right arrow key to navigate from the same toggle button to the help menu, even when the logic of the code seems to be correct.
Still working on resolving it.

Fixes: #29465.

Screenshots and screen captures:

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

The issue for the left navigation from the help menu to the userlist toggle button is working with this PR. Although there is still an issue on using the right arrow key to navigate from the same toggle button to the help menu, even when the logic of the code seems to be correct.
Still working on resolving it.
@rs545837 rs545837 marked this pull request as draft March 30, 2024 15:33
@rs545837 rs545837 marked this pull request as ready for review April 2, 2024 00:56
@timabbott
Copy link
Sponsor Member

@rs545837 can you clean up the commented-out print statements?

@alya
Copy link
Contributor

alya commented Apr 15, 2024

I will hold off on next steps for reviewing this PR until the right arrow works as well.

@zulipbot zulipbot added size: M and removed size: S labels Apr 18, 2024
@rs545837
Copy link
Collaborator Author

rs545837 commented Apr 18, 2024

Hey @alya, should I go for a new PR for a cleaner commit history? I actually did make a new cleaner PR #29781.

@alya
Copy link
Contributor

alya commented Apr 18, 2024

Closing in favor of #29781. But next time, please push your changes to the same PR, rather than starting a new one.

@alya alya closed this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants