-
-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Left/Right Arrow Keys Navigation #29506
Conversation
- Fixes zulip#29067 - Gives other examples of URL templates required for other commonly used languages. - Other Code Playgrounds are added
This fixes the left arrow navigation from help menu to the userlist toggle button, but somehow the right navigation from the userlist toggle button to the help menu doesn't work, even though the logic seems to be correct.
Hello @rs545837, it seems like you have referenced #29465 in your pull request description, but you have not referenced them in your commit message description(s). Referencing an issue in a commit message automatically closes the corresponding issue when the commit is merged, which makes the issue tracker easier to manage. Please run An example of a correctly-formatted commit:
To learn how to write a great commit message, please refer to our guide. |
Thanks! Please clean up your commit history and post again to request a review. See here for guidelines. |
You will also need to make sure tests pass, and complete the self-review checklist. |
The issue for the left navigation from the help menu to the userlist toggle button is working with this PR. Although there is still an issue on using the right arrow key to navigate from the same toggle button to the help menu, even when the logic of the code seems to be correct.
Still working on resolving it.
Fixes: #29465.
Screenshots and screen captures:
Self-review checklist
(variable names, code reuse, readability, etc.).
Communicate decisions, questions, and potential concerns.
Individual commits are ready for review (see commit discipline).
Completed manual review and testing of the following: