Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Left/Right Arrow Keys Navigation #29506

Closed
wants to merge 14 commits into from
Closed

Left/Right Arrow Keys Navigation #29506

wants to merge 14 commits into from

Conversation

rs545837
Copy link
Collaborator

The issue for the left navigation from the help menu to the userlist toggle button is working with this PR. Although there is still an issue on using the right arrow key to navigate from the same toggle button to the help menu, even when the logic of the code seems to be correct.
Still working on resolving it.

Fixes: #29465.

Screenshots and screen captures:

Self-review checklist
  • Self-reviewed the changes for clarity and maintainability
    (variable names, code reuse, readability, etc.).

Communicate decisions, questions, and potential concerns.

  • Explains differences from previous plans (e.g., issue description).
  • Highlights technical choices and bugs encountered.
  • Calls out remaining decisions and concerns.
  • Automated tests verify logic where appropriate.

Individual commits are ready for review (see commit discipline).

  • Each commit is a coherent idea.
  • Commit message(s) explain reasoning and motivation for changes.

Completed manual review and testing of the following:

  • Visual appearance of the changes.
  • Responsiveness and internationalization.
  • Strings and tooltips.
  • End-to-end functionality of buttons, interactions and flows.
  • Corner cases, error conditions, and easily imagined bugs.

rs545837 and others added 13 commits March 2, 2024 13:08
- Fixes zulip#29067
- Gives other examples of URL templates required for other commonly used languages.
- Other Code Playgrounds are added
This fixes the left arrow navigation from help menu to the userlist toggle button, but somehow the right navigation from the userlist toggle button to the help menu doesn't work, even though the logic seems to be correct.
@zulipbot
Copy link
Member

Hello @rs545837, it seems like you have referenced #29465 in your pull request description, but you have not referenced them in your commit message description(s). Referencing an issue in a commit message automatically closes the corresponding issue when the commit is merged, which makes the issue tracker easier to manage.

Please run git commit --amend in your command line client to amend your commit message description with Fixes #29465..

An example of a correctly-formatted commit:

commit fabd5e450374c8dde65ec35f02140383940fe146
Author: zulipbot
Date:   Sat Mar 18 13:42:40 2017 -0700

    pull requests: Check PR commits reference when issue is referenced.

    Fixes #51.

To learn how to write a great commit message, please refer to our guide.

@alya
Copy link
Contributor

alya commented Mar 29, 2024

Thanks! Please clean up your commit history and post again to request a review. See here for guidelines.

@alya
Copy link
Contributor

alya commented Mar 29, 2024

You will also need to make sure tests pass, and complete the self-review checklist.

@rs545837 rs545837 closed this Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make keyboard navigation work for show/hide user list button
3 participants