Allow user to hide right sidebar on any width.

[amanagr]

discussion: https://chat.zulip.org/#narrow/stream/6-frontend/topic/Hide.20right.20sidebar

[alya]

Nice! I think we should adjust the tooltip to:

• Show user list [W]
• Hide user list <- No keyboard shortcut, since W doesn't work to hide it again.

[alya]

I also noticed a bug, where the user list opens in the wrong place.

1. Make your window wide.
2. Close the user list.
3. Press W to open it.

[timabbott]

I merged the prep commits, which all look like pretty safe refactors, as #29358, so this should be quite compact now.

[alya]

That's all the feedback I've got -- looks good to me otherwise!

[amanagr]

Fixed both the issues @alya mentioned. Thanks!

[alya]

Not a blocker for merging this, but ideally the left/right arrow keys would work for navigating between this button and the help menu.

[alya]

Looks good to me other than that, now! I tested with "Use full width on wide screens" turned on/off.

[timabbott]

The code basically lgtm. A few notes:

• I notice that when toggling it on/off, there's a bit of a positional flicker for the moment where the "Invite users" option is at the top; probably it's worth figuring out how to avoid that.
• It feels a bit weird that the visual appearance of the toggle widget is different when the sidebar is hidden vs. not. (Underline in wide screens, but that's missing in narrow ones). Let's have underline when it is open always.
• It feels like a bit of a void when collapsed; I wonder if anyone might be confused as to how to get it back. but probably that's a thing Vlad can debate once we have this test-deployed.
• I managed to get a state where the right sidebar was misplaced while fiddling with fluid layout widget; but I can't reproduce right now.

I think I'll try to test-deploy on chat.zulip.org anyway, but might be you get to these revisions before me.

[amanagr]

I notice that when toggling it on/off, there's a bit of a positional flicker for the moment where the "Invite users" option is at the top; probably it's worth figuring out how to avoid that.

This is happening since the rendering for the user list is more complex. If we toggle visibility instead of display, this doesn't happen. I think we can come back to it if more folks notice this since the solution would be to add transition on visibility / opacity.

[amanagr]

It feels a bit weird that the visual appearance of the toggle widget is different when the sidebar is hidden vs. not. (Underline in wide screens, but that's missing in narrow ones). Let's have underline when it is open always.

Added a commit for it.

[amanagr]

I managed to get a state where the right sidebar was misplaced while fiddling with fluid layout widget; but I can't reproduce right now.

I am not able to reproduce, do you recall what it looked like?

[timabbott]

I am not able to reproduce, do you recall what it looked like?

Yeah, the sidebar was all the way to the right. I think we can probably hope someone can reproduce on chat.zulip.org; maybe let's post it in #issues and crowdsource a reproduction recipe after merging.

[timabbott]

OK, I think we can merge this and fix forward from here, thanks @amanagr!

I think the flicker is probably distracting enough that it's worth some effort to fix. But I'm not sure I like the idea of moving to visibility, since that might entail the browser doing more background rendering work? Note sure. The ideas had would be to just do a requestAnimationFrame around the transition, or hiding/showing the "Invite users" first -- not sure if that could prevent it.

[alya]

Cool! I filed #29465 as a follow-up for keyboard nav.

[amanagr]

Yeah, the sidebar was all the way to the right. I think we can probably hope someone can reproduce on chat.zulip.org; maybe let's post it in #issues and crowdsource a reproduction recipe after merging.

Yeah, I had updated this PR with a fix for that.