Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements in lint hotkeys #1482

Closed
wants to merge 2 commits into from

Conversation

Niloth-p
Copy link
Collaborator

What does this PR do, and why?

  1. Adds a missing '--fix' flag in usage prompt.
  2. Adds the only missing docstring in the file.

Outstanding aspect(s)

I've kept them in separate commits, so that we can merge the first commit and keep the second commit in hold until we accumulate more docstrings or similar changes, if necessary.

How did you test this?

  • Manually - Visual changes

@zulipbot zulipbot added the size: S [Automatic label added by zulipbot] label Apr 14, 2024
@neiljp neiljp added the area: infrastructure Project infrastructure label Apr 17, 2024
@neiljp
Copy link
Collaborator

neiljp commented Apr 17, 2024

@Niloth-p While tidying this file isn't a priority, if you end up making useful changes to it while you're handling related tasks, but which don't fit into another PR, this PR does seem like a good place to accumulate them.

I'm going to merge the first commit manually since it also confused me recently :)

@Niloth-p Niloth-p closed this May 3, 2024
@Niloth-p Niloth-p deleted the minor-improv-lint-hotkeys branch May 3, 2024 03:19
@neiljp
Copy link
Collaborator

neiljp commented May 9, 2024

@Niloth-p It was ok to leave this PR as it was, but I guess you have this locally and are working on other aspects now? :)

@Niloth-p
Copy link
Collaborator Author

Niloth-p commented May 9, 2024

@Niloth-p It was ok to leave this PR as it was, but I guess you have this locally and are working on other aspects now? :)

Well, there's just a single docstring left unmerged. And I've included that in the lint-hotkeys update we do in #1484.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: infrastructure Project infrastructure size: S [Automatic label added by zulipbot]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants