Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

messages: WIP poll widget #1477

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

messages: WIP poll widget #1477

wants to merge 1 commit into from

Conversation

rsashank
Copy link
Member

@rsashank rsashank commented Mar 28, 2024

What does this PR do, and why?

Implementation for the polls widget WIP

Previous:
image

Current PR:
image

Outstanding aspect(s)

  • [ ]

External discussion & connections

How did you test this?

  • Manually - Behavioral changes
  • Manually - Visual changes
  • Adapting existing automated tests
  • Adding automated tests for new behavior (or missing tests)
  • Existing automated tests should already cover this (only a refactor of tested code)

Self-review checklist for each commit

  • It is a minimal coherent idea
  • It has a commit summary following the documented style (title & body)
  • It has a commit summary describing the motivation and reasoning for the change
  • It individually passes linting and tests
  • It contains test additions for any new behavior
  • It flows clearly from a previous branch commit, and/or prepares for the next commit

Visual changes

@zulipbot zulipbot added the size: M [Automatic label added by zulipbot] label Mar 28, 2024
@neiljp neiljp added area: message rendering PR awaiting update PR has been reviewed & is awaiting update or response to reviewer feedback labels Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: message rendering PR awaiting update PR has been reviewed & is awaiting update or response to reviewer feedback size: M [Automatic label added by zulipbot]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants