Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Upgrade codecov-action from v3 to v4. #1469

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

neiljp
Copy link
Collaborator

@neiljp neiljp commented Feb 9, 2024

What does this PR do, and why?

Actions are upgrading to node 20, which is anticipated to occur via this major version bump of codecov-action.

Other actions were upgraded recently; this action provided a note in a CI run which recommends upgrading this action too:

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: codecov/codecov-action@v3.
For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

(https://github.com/zulip/zulip-terminal/actions/runs/7838963350?pr=1468)

NOTE: This is currently paused over concern over the status of codecov/feedback#112

zulip/zulip currently uses v3 of the action. However, it seems that v3 is unlikely to bump to node 20 due to a need to avoid breakage, and will become unsupported due to its use of node 16, except for v3.1.5. So possibly this could be addressed with Zulip via an organization secret?

Outstanding aspect(s)

  • Concern over possible breakage? (see above)

External discussion & connections

  • Discussed in #zulip-terminal in topic
  • Fully fixes #
  • Partially fixes issue #
  • Builds upon previous unmerged work in PR #
  • Is a follow-up to work in PR #
  • Requires merge of PR #
  • Merge will enable work on #

How did you test this?

  • Manually - Behavioral changes
  • Manually - Visual changes
  • Adapting existing automated tests
  • Adding automated tests for new behavior (or missing tests)
  • Existing automated tests should already cover this (only a refactor of tested code)

Self-review checklist for each commit

  • It is a minimal coherent idea
  • It has a commit summary following the documented style (title & body)
  • It has a commit summary describing the motivation and reasoning for the change
  • It individually passes linting and tests
  • It contains test additions for any new behavior
  • It flows clearly from a previous branch commit, and/or prepares for the next commit

@neiljp neiljp added the area: infrastructure Project infrastructure label Feb 9, 2024
@zulipbot zulipbot added the size: XS [Automatic label added by zulipbot] label Feb 9, 2024
Noted as necessary in an annotation in a recent run of the lint-and-test
workflow, since the previous version uses a version of Node.js which is
deprecated.
@neiljp neiljp force-pushed the 2024-02-08-codecov-action-v3 branch from 184340b to f9d2286 Compare February 9, 2024 04:32
@neiljp neiljp added the further discussion required Discuss this on #zulip-terminal on chat.zulip.org label Feb 9, 2024
@@ -193,7 +193,7 @@ jobs:
- name: Run tests with pytest
run: pytest --cov-report=xml
- name: Upload coverage to Codecov
uses: codecov/codecov-action@v3
uses: codecov/codecov-action@v4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
uses: codecov/codecov-action@v4
uses: codecov/codecov-action@v4
with:
token: ${{ secrets.CODECOV_TOKEN }}

I’ve added this as a repository secret for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: infrastructure Project infrastructure further discussion required Discuss this on #zulip-terminal on chat.zulip.org size: XS [Automatic label added by zulipbot]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants