Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add emoji picker for reactions #566

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

chrisirhc
Copy link
Contributor

@chrisirhc chrisirhc commented Mar 15, 2024

TODO:

  • Tests
  • Localization
  • Add support for all emoji that aren't available by default in emoji_picker_flutter (e.g. symbols like *️⃣ , which are available in iamcal but not in emoji_picker_flutter) (Related: Use the official metadata as source  Fintasys/emoji_picker_flutter#153 )
  • Filter away emoji that were already added by current user (similar to previous ThumbsUp behavior)
  • Show 3-4 most recent emojis in the menu for reuse via final recentEmojis = await EmojiPickerUtils().getRecentEmojis();
  • Clean up commit messages to fit style guide

Demo:
Screen_recording_20240315_110944 Zulip Emoji.webm

Partially addresses #388

working version with majority of emojis

working version that handles keyboard and top edge clipping

replace add thumbs up button

add typings on emoji

fix error handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant