Zstack driver #1280

t-8ch · 2021-11-28T15:05:25Z

As discussed in #1226

This is a rebased version of your zstack_driver branch.
Most of the patches are 1:1 rebases of yours.

Beginning from my patches:

Updates the pom.xml files to match the current versions in the repo.
Is a small cleanup
Adds a new reset sequence that is necessary for my device.

My setup:

Slae.sh CC2652 Stick with firmware CC2652RB_coordinator_20210708 from Koenkk
Aqara Mini Switch
Philips Hue Dimmer switch

Current status:

The Aqara switch gets found but not fully discovered. This could maybe be a weak battery and I will retest it with a new one soon.
The Battery of the Philips switch is dead and I will have to get a new one, too.

Signed-off-by: Chris Jackson <chris@cd-jackson.com>

Hedda · 2021-11-29T13:24:45Z

Nice! Are you testing with Koenkk's firmware images from "develop" branch or "master" branch (currently "20210708"), or other?

https://github.com/Koenkk/Z-Stack-firmware/tree/master/coordinator/Z-Stack_3.x.0/bin

https://github.com/Koenkk/Z-Stack-firmware/tree/develop/coordinator/Z-Stack_3.x.0/bin

FYI, 20211114 currently in develop branch is based on TI SDK 5.30.00.56 comparing to it should in practice only have bug fixes.

t-8ch · 2021-11-29T13:26:51Z

@Hedda 20210708 as written in the PR description.

Aimen-Hammou · 2021-11-29T14:33:34Z

@t-8ch Hi, could you explain how did you test the code? I have a CC2562P with ZSTACK 3.X.0 and a zigbee thermostat; would like to test the code to it.

Edit: I forgot to add what I tried: Cloned the repository, run mvn clean install and it gives me error regarding missing headers(?)
used the .skip=true flag and still fails. Git cloned using Eclipse, SLF4J missing because MVN cannot run; Pretty confused on what to do.

(also: where did you find informations regarding ZStack Booting and startup sequence? Can't understand what changes between 1.2 to 3.X.0)

t-8ch · 2021-11-29T14:39:09Z

@Aimen-Hammou This should be explained in the docs. You should probably wait with enduser-testing until it is confirmed that it works in general.

Aimen-Hammou · 2021-11-29T14:42:29Z

@t-8ch Tried the DOCS, nothing. Even the main repository doesn't work tbh

t-8ch · 2021-11-29T14:44:05Z

@Aimen-Hammou Then it would be best to open a new ticket for that and describe the issue in more detail there.

Aimen-Hammou · 2021-11-29T14:46:29Z

@t-8ch Ok, thank you. Out of curiosity: where did you find informations regarding ZStack 3.X.0 and the startup process?

t-8ch · 2021-11-29T15:09:40Z

@Aimen-Hammou The schematics show that RTS and DTR of the USB-UART adapter are wired to Reset and BOOTLOADER_ENABLE of the CC2652. So what this does is: Assert BOOTLOADER_ENABLE and force reset the CC2652 which will then bypass the bootloader.
(This is specified in the CC2652 datasheet)

Hedda · 2021-11-29T15:17:06Z

where did you find informations regarding ZStack 3.X.0 ...

FYI, the latest versions of TI Z-Stack SDK documentation looks to be available from the official Texas Instruments source here:

https://dev.ti.com/tirex/explore/node?node=AGfGICF0XoQz0l9l-rT2Qg__BSEc4rl__LATEST

https://software-dl.ti.com/simplelink/esd/simplelink_cc13xx_cc26xx_sdk/5.30.00.56/exports/docs/Documentation_Overview.html

https://software-dl.ti.com/simplelink/esd/simplelink_cc13xx_cc26xx_sdk/5.30.00.56/exports/docs/zigbee/html/zigbee/znp_interface.html

https://software-dl.ti.com/simplelink/esd/simplelink_cc13xx_cc26xx_sdk/5.30.00.56/exports/docs/zigbee/html/zigbee/znp_interface.html#znp-software-command-interface

"SimpleLink CC13xx CC26xx SDK" (version 5.30.00 and later) covers CC2652 and CC1352 which are used for TI Zigbee Coordinator:

https://www.ti.com/tool/SIMPLELINK-CC13XX-CC26XX-SDK

PS: The very latest is TI SimpleLink CC13xx and CC26xx SDK version 5.30.00.56 which was released on the 27th of October 2021.

Aimen-Hammou · 2021-11-29T15:29:51Z

@t-8ch @Hedda Thank you so much for the time!

cdjackson · 2021-11-30T01:28:16Z

Thanks @t-8ch

Regarding the firmware that is being used for testing - is this a "standard" TI version? ie there's nothing too much different - just tweaking table sizes etc? I would just like that this conforms to the standard API and doesn't rely on anything from other projects that is non-standard.

Regarding the reset - again - is this standard on all devices, or is this somehow implementation specific. If it's implementation specific (as I suspect?) then it would be good to make this configurable so that it's not locked to the hardware you use. In the Ember driver I have a ResetProvider which if set can be used to generate reset sequences, and then different implementations can implement this as they see fit. I think it would be wise to do something similar to ensure we're implementation agnostic.

I think you know what you're doing here so probably you don't need me, but if there's anything you want me to answer or help with, just shout.

@Aimen-Hammou as I have said a few times now, if you have questions, then please open a ticket and I can try and help, however this project does compile just fine, so I'm not sure why you are getting errors. Please though, let's discuss separately.

t-8ch · 2021-11-30T05:21:15Z

@cdjackson This should be the difference to the vanilla Zstack firmware from TI: https://github.com/Koenkk/Z-Stack-firmware/blob/master/coordinator/Z-Stack_3.x.0/firmware.patch
It doesn't look to make any changes to the actual protocol.

A resetprovider looks reasonable. I will try to refactor that part during the cleanup phase.

As I got to it to generally recognize the Aqara Button I am confident in both the hardware and your existing code.
The failure for a complete pair I blame on the Button being a Xiaomi device.
Going forward I'll work with the switch, but it uses a not-so-common batterytype, and I did not yet get one of those.

.. but if there's anything you want me to answer or help with, just shout.

Thanks, will do.

Hedda · 2021-11-30T08:14:31Z

Regarding the firmware that is being used for testing - is this a "standard" TI version? ie there's nothing too much different - just tweaking table sizes etc? I would just like that this conforms to the standard API and doesn't rely on anything from other projects that is non-standard.

The patch that Koen applies to each of his builds can be found in that same repo with a changelog and steps on how it's compiled:

https://github.com/Koenkk/Z-Stack-firmware/blob/develop/coordinator/Z-Stack_3.x.0/CHANGELOG.md

https://github.com/Koenkk/Z-Stack-firmware/blob/develop/coordinator/Z-Stack_3.x.0/firmware.patch

https://github.com/Koenkk/Z-Stack-firmware/blob/develop/coordinator/Z-Stack_3.x.0/COMPILE.md

@Koenkk Perhaps you would be willing to futher summarize how your Z-Stack 3.x.0 coordinator FW builds differ from TI's default?

Summary from changelog shortened:

Increase memory heap
Turn on/off leds when joining is enabled/disabled
Fix Xiaomi E1 devices not (fully) working
Allow setting transmit power for CC2652P/CC1352P greater than 5dBm (max 20dBm), default transmit power is set to 9dBm
Increase MAC buffers, increases performance on message burst and reduces MAC_TRANSACTION_OVERFLOW errors
LED control
Fix joining not working when joining is only permitted on specific router
Forward message to host even when profileID does not match
Optimize network parameters (according to https://www.ti.com/lit/an/swra650b/swra650b.pdf)
Change default CC2652R/CC2652RB/CC1352P-2/CC2652P transmit power from 0dBm to 5dBm
Potential fix for Hue end devices disconnecting
Expose AssocAdd function
Allow support for Samsung SmartThings PGC410EU presence sensor (link)
Fix commands to long sleeping end devices failing when directly connected to coordinator (e.g. Xiaomi JTYJ-GD-01LM/BW)
Expose AssocRemove function
Remove and rediscover route on source route failure (should fix issues with e.g. Hue enddevices dropping off) (more info)
Fix devices not able to reconnect when attempt unsecured rejoin (more info)
Enable parent announce, fixes devices not reachable when changing parents while coordinator is down.
Increase max number of Zigbee 3.0 devices that can join to 200
Increased group command buffer

upstream fixes from Texas Instruments SimpleLink SDK:

https://software-dl.ti.com/simplelink/esd/simplelink_cc13xx_cc26xx_sdk/5.30.01.01/exports/changelog.html

lgtm-com · 2021-12-01T09:50:48Z

This pull request introduces 7 alerts when merging 7dd394a into 2318aa5 - view on LGTM.com

new alerts:

4 for Dereferenced variable may be null
2 for Spurious Javadoc @param tags
1 for Useless comparison test

Hedda · 2021-12-20T13:59:48Z

My setup:

Slae.sh CC2652 Stick with firmware CC2652RB_coordinator_20210708 from Koenkk

Aqara Mini Switch

Philips Hue Dimmer switch

Current status:

The Aqara switch gets found but not fully discovered. This could maybe be a weak battery and I will retest it with a new one soon.

FYI, the latest firmware from Koenkk's develop branch contains a fix for newer Aqara E1 / Xiaomi E1 devices + TI's upstream fixes:

https://github.com/Koenkk/Z-Stack-firmware/tree/develop/coordinator/Z-Stack_3.x.0/bin

https://github.com/Koenkk/Z-Stack-firmware/blob/develop/coordinator/Z-Stack_3.x.0/CHANGELOG.md

Update! Z-Stack 3.x.0 20211217 release has now been copied to their master branch and as such should be seen as stable:

https://github.com/Koenkk/Z-Stack-firmware/tree/master/coordinator/Z-Stack_3.x.0/bin

https://github.com/Koenkk/Z-Stack-firmware/blob/master/coordinator/Z-Stack_3.x.0/CHANGELOG.md

Note however that new firmware does however not specifically mention the even newer Aqara T1 / Xiaomi T1 series of devices.

PS: Regardless, Aqara and Xiaomi devices (as well as Tuya manufactured Zigbee devices) do not make for a good reference as they are infamously known for deviating from standard Zigbee Cluster Library specification causing interoperability/compatibility issues.

NathanSweet · 2022-02-22T21:15:31Z

I'm interested in this PR. Has there been any more progress?

Hedda · 2022-04-07T09:27:36Z

@t-8ch Any news/updates on this PR for Z-Stack 3.0 Zigbee Coordinator driver support (to be used in openHAB ZigBee Binding)?

stale · 2022-07-31T03:02:51Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Hedda · 2022-08-02T15:35:04Z

@t-8ch Any chance to get this merged?

Hedda · 2022-09-28T07:21:07Z

FYI; @leonschenk posted now in OpenHAB community forum here https://community.openhab.org/t/discussion-about-texas-instruments-z-stack-3-0-and-cc2652-and-cc1352-zigbee-coordinator-adapters-with-openhab-zigbee-binding/129385/4 that he now picked up the development where @t-8ch left it, forking his branch of the zstack driver with Z-Stack 3 support to https://github.com/leonschenk/com.zsmartsystems.zigbee/tree/zstack/initial in order to continue the work of adding initial support for CC2652/CC1352 based adapters with Z-Stack 3.x.0 Zigbee Coordinator firmware https://github.com/Koenkk/Z-Stack-firmware/tree/master/coordinator/Z-Stack_3.x.0/bin so hopefully once he feels it works good enough for review he will create a new pull request to the com.zsmartsystems.zigbee ZigBee Cluster Library Java framework//libraries that OpenHAB's ZigBee Binding and other projects depend on https://github.com/zsmartsystems/com.zsmartsystems.zigbee

cdjackson · 2022-09-28T07:28:59Z

@Hedda there is no real need to cross post this everywhere. I'm in discussion about this already and we don't really need spam posts everywhere which doesn't add anything!

leonschenk · 2022-11-05T07:53:52Z

I'm interested in this PR. Has there been any more progress?

@NathanSweet I have a working development going on in #1352

NathanSweet · 2022-11-05T14:56:16Z

@leonschenk Thanks for the ping. While I'd love to be able to interface with ZB directly using Java, it's so low level that for me it would need to work out of the box. I ended up using zigbee2mqtt, which has been working very well and has good support. It's a little annoying to run a node process but at least the API via MQTT makes interfacing with it very easy.

stale · 2023-01-07T22:30:10Z

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

cdjackson · 2023-02-05T22:52:40Z

com.zsmartsystems.zigbee/src/main/java/com/zsmartsystems/zigbee/transport/ZigBeePort.java

@@ -85,6 +85,16 @@ public interface ZigBeePort {
     */
    void purgeRxBuffer();

+    /**


These methods should not be added here. This interface is not specific to a serial port - that is implemented in the ZigBeeSerialPort class. Here we need to keep it more abstract as there are other implementations of this such as an SPI implementation.

cdjackson · 2023-02-05T22:54:06Z

...artsystems.zigbee.serial/src/main/java/com/zsmartsystems/zigbee/serial/ZigBeeSerialPort.java

@@ -273,19 +273,21 @@ public void purgeRxBuffer() {
        }
    }

-    public boolean setDtr(boolean state) {
+    @Override


These methods should not be changed. They can't be defined in the interface as per the other comment, so th @Override should be removed, and my preference would be not to change the return statement as I don't know if this is used by other users. If it is, it will be a breaking change that I would prefer to avoid.

cdjackson · 2023-02-05T22:56:25Z

...bee.dongle.cc2531/src/test/java/com/zsmartsystems/zigbee/dongle/cc2531/Cc2351TestPacket.java

@@ -111,5 +111,13 @@ public boolean open(int baudRate, FlowControl flowControl) {
        @Override
        public void purgeRxBuffer() {
        }
+


As per other comments this probably needs to be removed.

cdjackson · 2023-02-05T22:57:04Z

...test/java/com/zsmartsystems/zigbee/dongle/ember/internal/EmberFirmwareUpdateHandlerTest.java

@@ -202,6 +202,14 @@ public boolean open(int baudRate, FlowControl flowControl) {
        public void purgeRxBuffer() {
        }

+        @Override
+        public void setDtr(boolean state) {


Likewise - should be removed.

cdjackson · 2023-02-05T22:57:26Z

...er/src/test/java/com/zsmartsystems/zigbee/dongle/ember/internal/ash/AshFrameHandlerTest.java

@@ -206,6 +206,14 @@ public boolean open(int baudRate, FlowControl flowControl) {
        public void purgeRxBuffer() {
        }

+        @Override


Please remove

cdjackson · 2023-02-05T23:01:50Z

...autocode/src/main/java/com/zsmartsystems/zigbee/dongle/zstack/autocode/CommandGenerator.java

+            outputWithLinebreak(out, "", structure.description);
+            out.println(" * <p>");
+        }
+        out.println(" * Note that this code is autogenerated. Manual changes may be overwritten.");


I'd suggest to remove the @author tag below and instead add the @Generated annotation.

@Generated(value = "com.zsmartsystems.zigbee.autocode.ZigBeeCodeGenerator", date = "2020-12-25T10:11:19Z")

cdjackson and others added 12 commits November 27, 2021 11:49

Initial Z-Stack driver

d7bb311

Signed-off-by: Chris Jackson <chris@cd-jackson.com>

Update to use separate serializer/deserialzer classes

15e96a7

Signed-off-by: Chris Jackson <chris@cd-jackson.com>

Update CLI commands to get more visibility of stack

db3802f

Signed-off-by: Chris Jackson <chris@cd-jackson.com>

Initialisation update

d99f265

Signed-off-by: Chris Jackson <chris@cd-jackson.com>

Handle HA1.2 join

ab7768d

Signed-off-by: Chris Jackson <chris@cd-jackson.com>

Refactored after 1.2 breaking changes

6f8d8f3

Signed-off-by: Chris Jackson <chris@cd-jackson.com>

Initialisation changes

3e952d8

Signed-off-by: Chris Jackson <chris@cd-jackson.com>

Update for SeqNum bug

ee849e0

Signed-off-by: Chris Jackson <chris@cd-jackson.com>

Finalise initialisation

506646a

Signed-off-by: Chris Jackson <chris@cd-jackson.com>

Remove APS Counter setting as this is now default

17ecf18

Signed-off-by: Chris Jackson <chris@cd-jackson.com>

Update POM version for zstack dongle

d0e472f

console: mark baudrate as required

d3ab231

t-8ch force-pushed the zstack_driver branch from 1bc1116 to 93514d1 Compare December 1, 2021 09:13

Use hardware bootloader reset if necessary

7dd394a

t-8ch force-pushed the zstack_driver branch from 93514d1 to 7dd394a Compare December 1, 2021 09:36

Hedda mentioned this pull request Dec 1, 2021

Support for CC2562 coordinator openhab/org.openhab.binding.zigbee#605

Open

cdjackson added CC2531 enhancement labels Dec 5, 2021

stale bot added the wontfix label Jul 31, 2022

stale bot removed the wontfix label Aug 2, 2022

stale bot added the wontfix label Jan 7, 2023

cdjackson removed the wontfix label Jan 8, 2023

cdjackson reviewed Feb 5, 2023

View reviewed changes

cdjackson mentioned this pull request Feb 5, 2023

Zstack 3.x.0 support for TI CC2652 chip #1352

Open

cdjackson force-pushed the master branch from 2395d63 to 90bf574 Compare May 5, 2023 20:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Zstack driver #1280

Zstack driver #1280

t-8ch commented Nov 28, 2021

Hedda commented Nov 29, 2021 •

edited

t-8ch commented Nov 29, 2021

Aimen-Hammou commented Nov 29, 2021 •

edited

t-8ch commented Nov 29, 2021

Aimen-Hammou commented Nov 29, 2021

t-8ch commented Nov 29, 2021

Aimen-Hammou commented Nov 29, 2021

t-8ch commented Nov 29, 2021

Hedda commented Nov 29, 2021

Aimen-Hammou commented Nov 29, 2021

cdjackson commented Nov 30, 2021

t-8ch commented Nov 30, 2021

Hedda commented Nov 30, 2021 •

edited

lgtm-com bot commented Dec 1, 2021

Hedda commented Dec 20, 2021 •

edited

NathanSweet commented Feb 22, 2022 •

edited

Hedda commented Apr 7, 2022

stale bot commented Jul 31, 2022

Hedda commented Aug 2, 2022

Hedda commented Sep 28, 2022 •

edited

cdjackson commented Sep 28, 2022

leonschenk commented Nov 5, 2022

NathanSweet commented Nov 5, 2022

stale bot commented Jan 7, 2023

cdjackson Feb 5, 2023

cdjackson Feb 5, 2023

cdjackson Feb 5, 2023

cdjackson Feb 5, 2023

cdjackson Feb 5, 2023

cdjackson Feb 5, 2023

Zstack driver #1280

Are you sure you want to change the base?

Zstack driver #1280

Conversation

t-8ch commented Nov 28, 2021

Hedda commented Nov 29, 2021 • edited

t-8ch commented Nov 29, 2021

Aimen-Hammou commented Nov 29, 2021 • edited

t-8ch commented Nov 29, 2021

Aimen-Hammou commented Nov 29, 2021

t-8ch commented Nov 29, 2021

Aimen-Hammou commented Nov 29, 2021

t-8ch commented Nov 29, 2021

Hedda commented Nov 29, 2021

Aimen-Hammou commented Nov 29, 2021

cdjackson commented Nov 30, 2021

t-8ch commented Nov 30, 2021

Hedda commented Nov 30, 2021 • edited

lgtm-com bot commented Dec 1, 2021

Hedda commented Dec 20, 2021 • edited

NathanSweet commented Feb 22, 2022 • edited

Hedda commented Apr 7, 2022

stale bot commented Jul 31, 2022

Hedda commented Aug 2, 2022

Hedda commented Sep 28, 2022 • edited

cdjackson commented Sep 28, 2022

leonschenk commented Nov 5, 2022

NathanSweet commented Nov 5, 2022

stale bot commented Jan 7, 2023

cdjackson Feb 5, 2023

Choose a reason for hiding this comment

cdjackson Feb 5, 2023

Choose a reason for hiding this comment

cdjackson Feb 5, 2023

Choose a reason for hiding this comment

cdjackson Feb 5, 2023

Choose a reason for hiding this comment

cdjackson Feb 5, 2023

Choose a reason for hiding this comment

cdjackson Feb 5, 2023

Choose a reason for hiding this comment

Hedda commented Nov 29, 2021 •

edited

Aimen-Hammou commented Nov 29, 2021 •

edited

Hedda commented Nov 30, 2021 •

edited

Hedda commented Dec 20, 2021 •

edited

NathanSweet commented Feb 22, 2022 •

edited

Hedda commented Sep 28, 2022 •

edited