Auto generate config.yaml on shell start #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the current instruction for updating keys is slightly unintuitive
Having to manually run
ruby generate.rbis different than the way users might expect. Instead, I think it makes more sense to ask users to resource~/.zshrcor restart their terminal.I don't think it's BETTER to restart zsh/resource
~/.zshrc(in fact, it's actually slower), but rather it fits more in line with standard command-line tools conventions. Most CLI tools I know of may ask users to restart/resource their shell to apply changes.Anyways, this PR isn't trying to change any functionality of zsh-apple-touchbar, just making a bit more sense for once process