Proposal to add integration tests #23
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, git wants to manage this repo instead of one for test purposes
Adds a test structure that creates a test repo and runs against it, comparing the output to expected. Also adds two initial tests to prove the point.
This organization makes it easier to add new tests and to avoid re-implementing the setup/cleanup loop around each case
Not fully on par with most testing frameworks, but something is better than nothing!
- Default author info isn't always enough
|
Sorry for the late reply. I had a quick look and it seems a good approach. Great idea to use a marker to prevent deleting the wrong directory. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
IMHO, one of the trickier things about working on shell projects like this is ensuring one doesn't make an accidental edge case break. To that end, I've started some integration tests. The test cases aren't nearly complete and the commits could probably do with a good squash at the end, but I wanted to start a discussion as to whether this was wanted by anyone aside from me and if this was a valid starting point.
Goal
My eventual goal with this would be to achieve near full coverage of
zshrc.shas well as the ability to automate these tests somewhat with github actions etc. This would also serve the conversation in #21 about finding a minimum zsh version as it would be possible to bisect zsh versions with these tests.Strategy
These tests are intended to each create a git repo in a certain precise state, run the
git_super_statuscommand and validate the produced output, theme colors and all.Advantages
Disadvantages/risks
Any & all thoughts on this approach are appreciated, thank you!