Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

achordion: allow chording of thumb keys and non-thumb keys #381

Closed
wants to merge 1 commit into from

Conversation

danieldk
Copy link

The Achordion library rejects chording of keys on the same half to avoid accidentally triggering e.g. home row mods when rolling during typing.

The default logic does not consider thumb keys separately. However, this makes it hard to trigger keys on a layer when the key is on the same hand as the thumb key used for layer-tap. Since accidental overlaps between thumb keys and non-thumb keys are infrequent (probably less frequently overlap between the left and right hands), it makes more sense to consider the thumb keys to be separate from non-thumb keys for the chording check.

This change overrides the chording check in this manner for the Voyager.

The Achordion library rejects chording of keys on the same half to avoid
accidentally triggering e.g. home row mods when rolling during typing.

The default logic does not consider thumb keys separately. However, this
makes it hard to trigger keys on a layer when the key is on the same
hand as the thumb key used for layer-tap. Since accidental overlaps
between thumb keys and non-thumb keys are infrequent (probably less
frequently overlap between the left and right hands), it makes more
sense to consider the thumb keys to be separate from non-thumb keys for
the chording check.

This change overrides the chording check in this manner for the Voyager.
@puchupala
Copy link

You may also write a custom achordion_chord() function in keymap.c to explicitly allow chording with thumb keys on the same side without having to modify Achordion or QMK. https://getreuer.info/posts/keyboards/achordion/index.html#achordion_chord

@danieldk danieldk closed this May 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants