achordion: allow chording of thumb keys and non-thumb keys #381
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Achordion library rejects chording of keys on the same half to avoid accidentally triggering e.g. home row mods when rolling during typing.
The default logic does not consider thumb keys separately. However, this makes it hard to trigger keys on a layer when the key is on the same hand as the thumb key used for layer-tap. Since accidental overlaps between thumb keys and non-thumb keys are infrequent (probably less frequently overlap between the left and right hands), it makes more sense to consider the thumb keys to be separate from non-thumb keys for the chording check.
This change overrides the chording check in this manner for the Voyager.