Fix caps lock status not turning off on layer 1 for Moonlander #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes the caps lock status not turning off on layer 1. Default behavior of indicator led 6 is layer indicator taking priority. Setting a config flag `PRIORITY_CAPS_LED` makes indicator led 6 be the caps lock status. Signed-off-by: Anthony Amanse <ghieamanse@gmail.com>
AnthonyAmanse
force-pushed
the
fix/caps_status
branch
from
9aedf4d
to
362d9c4
Compare
|
It may be better to outright disable the caps lock LED for layer indication when caps lock indication is enabled. Eg, have that let be exclusively for caps lock. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the caps lock status not turning off on layer 1.
Default behavior of indicator led 6 is layer indicator taking
priority. Setting a config flag
PRIORITY_CAPS_LEDmakes indicatorled 6 be the caps lock status.
Signed-off-by: Anthony Amanse ghieamanse@gmail.com