Validate if string is null

[lucodifier]

No description provided.

[zpao]

We shouldn't be getting null/undefined in here. If we want the component to gracefully handled null/undefined (which, I don't know that I do) then it should be captured in render and we should return null. But as I noted on your issue, your code should probably check values to begine with.

[lucodifier]

The Value do not is Empty or Null. Error: [image: image.png]

…

On Fri, Sep 10, 2021 at 8:53 PM Paul O’Shannessy ***@***.***> wrote: ***@***.**** requested changes on this pull request. We shouldn't be getting null/undefined in here. If we want the component to gracefully handled null/undefined (which, I don't know that I do) then it should be captured in render and we should return null. But as I noted on your issue, your code should probably check values to begine with. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#166 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANRSLGAWWTGMW6GGKYVP2V3UBKK6PANCNFSM5D2EMDYQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[lucodifier]

And, with this palliative code: [image: image.png] QRCode is generated: [image: image.png] The value is: https://homologacao.nfe.fazenda.sp.gov.br/cteConsulta/consulta/publica/ConsultarCTe.aspx?chaveAcesso=31210960860087003114641001000004131828017483 Thanks.

…

On Tue, Sep 14, 2021 at 8:09 PM Luciano Robe ***@***.***> wrote: The Value do not is Empty or Null. Error: [image: image.png] On Fri, Sep 10, 2021 at 8:53 PM Paul O’Shannessy ***@***.***> wrote: > ***@***.**** requested changes on this pull request. > > We shouldn't be getting null/undefined in here. If we want the component > to gracefully handled null/undefined (which, I don't know that I do) then > it should be captured in render and we should return null. But as I > noted on your issue, your code should probably check values to begine with. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <#166 (review)>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ANRSLGAWWTGMW6GGKYVP2V3UBKK6PANCNFSM5D2EMDYQ> > . > Triage notifications on the go with GitHub Mobile for iOS > <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> > or Android > <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. > >

[lucodifier]

In addition, the error occurs in this lib qr.js/lib/QRCode and for some unknown reason passes null value to function convertStr. That's why validating the null value resolves per hour. This is my html code: [image: image.png] Where the value of model.qrCodeUrl is a string containing a URL. Regards.

…

On Tue, Sep 14, 2021 at 8:15 PM Luciano Robe ***@***.***> wrote: And, with this palliative code: [image: image.png] QRCode is generated: [image: image.png] The value is: https://homologacao.nfe.fazenda.sp.gov.br/cteConsulta/consulta/publica/ConsultarCTe.aspx?chaveAcesso=31210960860087003114641001000004131828017483 Thanks. On Tue, Sep 14, 2021 at 8:09 PM Luciano Robe ***@***.***> wrote: > The Value do not is Empty or Null. > > Error: > > [image: image.png] > > On Fri, Sep 10, 2021 at 8:53 PM Paul O’Shannessy < > ***@***.***> wrote: > >> ***@***.**** requested changes on this pull request. >> >> We shouldn't be getting null/undefined in here. If we want the component >> to gracefully handled null/undefined (which, I don't know that I do) then >> it should be captured in render and we should return null. But as I >> noted on your issue, your code should probably check values to begine with. >> >> — >> You are receiving this because you authored the thread. >> Reply to this email directly, view it on GitHub >> <#166 (review)>, >> or unsubscribe >> <https://github.com/notifications/unsubscribe-auth/ANRSLGAWWTGMW6GGKYVP2V3UBKK6PANCNFSM5D2EMDYQ> >> . >> Triage notifications on the go with GitHub Mobile for iOS >> <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> >> or Android >> <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. >> >> >

[zpao]

I can't see what your code is, there are no images inline here (I think responding via email may not include those). That said, I'm fairly certain your code must be doing something that's resulting in null/undefined being passed in. Maybe via garbage collection of that model object and a re-render.