Update Datacite JSON #3280
Merged
Update Datacite JSON #3280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mainly to account for better publication metadata since Metadata Schema v. 4.4, also some additional improvements
adam3smith
commented
Mar 22, 2024
adam3smith
commented
Mar 22, 2024
AbeJellinek
requested changes
Mar 22, 2024
Datacite JSON.js
Outdated
| @@ -173,14 +179,17 @@ function doImport() { | |||
| else if (contributor.nameType == "Personal") { | |||
| item.creators.push(ZU.cleanAuthor(contributor.name, role)); | |||
| } | |||
| else { | |||
| item.creators.push({ lastName: contributor.name, creatorType: role, fieldMode: 1 }); | |||
| else { | |||
Datacite JSON.js
Outdated
| else { | ||
| item.creators.push({ lastName: contributor.name, creatorType: role, fieldMode: 1 }); | ||
| else { | ||
| item.creators.push({ lastName: contributor.name, creatorType: role, fieldMode: 1 }); |
Datacite JSON.js
Outdated
Comment on lines
303
to
305
| lastName: contributor.familyName, | ||
| firstName: contributor.givenName, | ||
| creatorType: role |
There was a problem hiding this comment.
Suggested change
| lastName: contributor.familyName, | |
| firstName: contributor.givenName, | |
| creatorType: role | |
| lastName: contributor.familyName, | |
| firstName: contributor.givenName, | |
| creatorType: role |
Co-authored-by: Abe Jellinek <jellinek@berkeley.edu>
|
@AbeJellinek I think this should be all set |
|
@AbeJellinek -- currently all publishers/repositories import as [object Object] from Datacite. Could we get this merged? The CI just times out. |
|
Thanks - sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mainly to account for better publication metadata since Metadata Schema v. 4.4, also some additional improvements