Squarespace #3243
Open
Squarespace #3243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Translator for Squarespace blogs. Should work with most templates Only search pages that put a data-url attribute on results are supported
Normalize line endings to CR LF
We are in 2024
Remove code to scrape <meta name="datePublished"> tags, which Squarespace blogs don't use. They use <meta itemprop="datePublished"> instead, which is already handled
Add test case for tags
AbeJellinek
requested changes
Jan 31, 2024
Squarespace.js
Outdated
| } | ||
|
|
||
| function getMetadataItem(doc, prop) { | ||
| return attr(doc, 'html>head>meta[itemprop="' + prop + '"]', 'content'); |
There was a problem hiding this comment.
Any reason we need the extra specification and not just meta[itemprop="${prop}"]? <meta> tags are valid in the body and we don't normally restrict the selector unless there's a very good performance argument for doing so (e.g. detection in Embedded Metadata).
There was a problem hiding this comment.
I copied the selector from some other translator (Embedded Metadata probably). I'll simplify it
As suggested by @AbeJellinek: - use relative URLs in search results - accept meta tags from anywhere in the page - don't set website type - use ZU.cleanAuthor to build the creator - use Array.from instead of Array.prototype.slice.call Additionally, call ZU.trimInternal on the abstract, to normalize whitespace Update test cases accordingly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translator for Squarespace blogs. Should work with most templates
Only search pages that put a data-url attribute on results are supported
Has a priority of 300 so that it has higher priority than Embedded Metadata, which is supported for Squarespace blogs but insufficient