Add translator for Public Record Office Victoria

[wragge]

New translator for checking. I think it's pretty straightforward as the metadata is all coming from their public API. Thanks!

[adam3smith]

A couple of nits, one question for you, one for @AbeJellinek ; otherwise this does look straightforward, yes.

[adam3smith]

@AbeJellinek -- could you weigh in on this. This will work (i.e. write the string to Extra), but I'm not sure how comfortable we are using this behavior in translators.

[wragge]

I was going on what has been recommended in the forums for date ranges. Eg: https://forums.zotero.org/discussion/63073/date-year-range and https://forums.zotero.org/discussion/105949/date-range

[AbeJellinek]

I think this will work everywhere? But it's safer (and more indicative of the final result) to do

item.extra = (item.extra ? item.extra + "\n" : "") + "Issued: " + startDate + "/" + endDate;

Even though that is definitely more verbose.

[AbeJellinek]

And we should use that for archive-place as well. ("Archive Place: " should work.)

[adam3smith]

Right, I was referring to using item.issued to putting this into Extra -- the approach to date ranges using Extra is definitely right.

I kind of like the less verbose version using item.issued -- is there actually a reason not to do this? will also be much faster to convert if we do get a better date field.

[AbeJellinek]

No, I guess not, assuming that actually works everywhere.

[AbeJellinek]

It seems to, although it translates archive-place to Archive-place, which is a little uglier than if we added it to Extra manually as Archive Place. That's arguably a client bug, though.

[wragge]

I've changed all the extra additions to use the more verbose form. I also changed series to Archive Collection to be in line with CSL.

[wragge]

I think this is ready to go now?

[AbeJellinek]

OK, made a couple nitpicky formatting/regex changes.

A few remaining things:

1. I'm not sure we want to set the Library Catalog to something containing "API" - that field isn't really used in most citation styles, but it's still a little confusing and not really relevant. The default (the translator label) is fine.
2. "Download file as PDF" - "Full Text PDF"? For consistency.
3. Is the manifest useful? We don't normally attach machine-readable-only files in translators. We could put it behind a hidden pref, but it seems to me like the sort of thing that you'd attach manually if you wanted it.

[AbeJellinek]

Oh, and

4. If we're attaching the PDF, why attach the image? Are the PDFs often very large? (I'm not confident that snapshot: false will prevent a non-text/html attachment from being attached...)