Fixes zotero/translators#3124 by adding translator for TinRead #3223
Conversation
| } | ||
|
|
||
| async function scrape(doc, _url = doc.location.href) { | ||
| doc.getElementById("DirectLink").click(); |
There was a problem hiding this comment.
We can't rely on direct interaction with the webpage. While that will work in some current environments, it won't work in all environments (e.g., translation-server) and generally won't be possible in browsers in the future. So for a case like this, you'd want to figure out what the click kicked off and replicate that in code (which would also avoid an unseemly hard-coded delay).
There was a problem hiding this comment.
The MARCXML export URL looks like /marcexport.svc?enc=UTF-8&fmt=xml&id=203393&items=none&marc=Current&type=bib, so we can probably just substitute in the current item ID, which is in the URL after /bibliographic_view/.
| } | ||
|
|
||
| async function scrape(doc, _url = doc.location.href) { | ||
| doc.getElementById("DirectLink").click(); |
There was a problem hiding this comment.
The MARCXML export URL looks like /marcexport.svc?enc=UTF-8&fmt=xml&id=203393&items=none&marc=Current&type=bib, so we can probably just substitute in the current item ID, which is in the URL after /bibliographic_view/.
- changed label to include "Library Catalog" - improved regex for matching URL - added a few lines to `detectWeb` to allow for early failure - stylistic changes
… using resource ID
|
@AbeJellinek Thanks for all the feedback! I've implemented just about all of your suggestions, but the search page test is giving me a bit of trouble. I added a test, but it's currently failing with this opaque error message every time: Not sure what this means, but I'll continue trying to troubleshoot. It may be that I don't understand the search page tests very well in general. The example given in the docs here seems to suggest that a test case for a search page can consist of no more than a check that |
|
Because of the debacle with issue #3225 I decided to try rerunning the search page test in Zotero 7 and... this time it worked! Huzzah! |
Co-authored-by: Abe Jellinek <jellinek@berkeley.edu>
Co-authored-by: Abe Jellinek <jellinek@berkeley.edu>
See discussion of
zotero/translators#3124. AddedTinREAD.jswhich acts as a basic translator for TinRead records using exportable MARCXML files. Could probably still use some tweaking...