Modification of OSF translator #3219
Conversation
This is intended to address the [issue#3188](zotero#3188) I have made two modifications. 1. Modify `detectWeb` function to ensure that OSF Projects are recognized as "Web Page" instead of "Journal Article." 2. Modify `scrape` function to customize the citation information for OSF Projects.
There was a problem hiding this comment.
For what it's worth, I think this PR will not achieve its stated goal. On the one hand, this translator doesn't really work for osf.io (none of the tests pass, too) - looks like there were significant layout changes and detectWeb() no longer detects anything; on the other hand, ironically, the Embedded Metadata translator kicks in instead on /preprint/ URLs, while the other URLs are handled by the generic webpage snapshot one - i.e., already doing exactly what you seem to want to achieve here.
I'd say this translator needs a complete overhaul (asyncification + adjustments for the layout changes at least) instead. If you're up to that, feel free to give it a try. If not, let me know and I can take a look.
This is intended to address the issue#3188
I have made two modifications.
detectWebfunction to ensure that OSF Projects are recognized as "Web Page" instead of "Journal Article."scrapefunction to customize the citation information for OSF Projects.