Add translator for Libris #3184
Conversation
Libris is a service by The National Library of Sweden ("Kungliga
biblioteket"). It collects information from several Swedish
libraries. For more information see
http://libris.kb.se/help/about_libris_eng.jsp?language=en.
This translator is based on the translator for National Library of
Poland ISBN. Based on the discussion in zotero#3036 it filters only books
published in Sweden. It uses the Xsearch API:
http://libris.kb.se/help/xsearch_eng.jsp?language=en.
|
I'm not sure why the tests failed. Looks like maybe they were timed out? I found another recent PR where they failed after 10 minutes: https://github.com/zotero/translators/actions/runs/6708719978/job/18230143937?pr=3173. Is there a way to re-run the tests? |
|
re-running won't fix the tests -- this looks like it's getting stuck running the tests and then just aborting after 10mins. Looks good to me otherwise, I'm glad to see more localized ISBN import! |
|
Does that mean the test fails in the CI? I can't tell from the logs and it passes locally for me. |
|
Right, the CI tries to not just test linting but also run the translator test in an emulated environment and that just seems broken here and possibly for search translators more generally. That should get fixed, but it's not anything you need to worry about. |
|
I just want to doublecheck so I haven't missed anything: is there anything I need to do before this can be reviewed? |
|
Thanks, looks good, just one nitpick. |
|
Oh, and some naming nitpicks:
|
|
Tanks for the review. |
|
Is there anything else that needs to be done before this can be merged? |
|
Thank you! |
Libris is a service by The National Library of Sweden ("Kungliga biblioteket"). It collects information from several Swedish libraries. For more information see
http://libris.kb.se/help/about_libris_eng.jsp?language=en.
This translator is based on the translator for National Library of Poland ISBN. Based on the discussion in #3036 it filters only books published in Sweden. It uses the Xsearch API:
http://libris.kb.se/help/xsearch_eng.jsp?language=en.