Move all linters to pre-commit. #1164
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sallner
force-pushed
the
more-pre-commit
branch
3 times, most recently
from
b9923a9
to
c3aa228
Compare
sallner
force-pushed
the
more-pre-commit
branch
from
df93db9
to
1cb817c
Compare
This fixes some tests.
Those checkers are not able to work on single files present in a commit but need conecptionally work on the whole repository (check-manifest) and thus are not suited to be run before each commit, but only in the CI.
sallner
force-pushed
the
more-pre-commit
branch
from
73ad299
to
3743bf1
Compare
icemac
requested changes
Sep 22, 2023
icemac
reviewed
Sep 22, 2023
These are mostly documentation changes. Some of the docstrings might influence the public availability of the methods on an object. Co-authored-by: Michael Howitz <mh@gocept.com>
icemac
approved these changes
Sep 22, 2023
|
@dataflake What do you think about these changes? |
|
Reviewing 260 files with a bunch of changes is insane. I am missing information what those changes are about. Is it all just changing comment formatting? Secondly, I still don't know what the change in developer experience is. What exactly does this switch to pre-commit do? Does it now force-run stuff on every commit? Locally? Remotely? Does it make changes to my commits that I cannot control? Do I get explicit feedback what changes are made? I have no idea what this really does. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first attempt to solve #1031. Hopefully the PR will get corrected with the current github action configuration.
I have chosen to use GHA over pre-commit.ci directly, as it is not possible to deactivate the autoupdates of the hooks in pre-commit.ci. The lite version via GHA does no autoupdates at all.
The aim would be to update the hooks only in zopefoundation/meta.
I intentionally did not run the pre-commit hook on my local machine to show the functionality on GHA. This way I also tried to separate the generated code changes with my manual ones.
Open issues/ideas:
sphinx-lintto lint the rst files, see https://github.com/pytest-dev/pytest-rerunfailures/pull/255/files as an example