Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LCV container tests #809

Merged
merged 21 commits into from May 22, 2019
Merged

LCV container tests #809

merged 21 commits into from May 22, 2019

Commits on May 15, 2019

  1. A start of tests using nock

    Sarah Allen committed May 15, 2019
    Copy the full SHA
    a2141bd View commit details
    Browse the repository at this point in the history

  2. Fix up tests and clean up error handling

    Sarah Allen committed May 15, 2019
    Copy the full SHA
    5054058 View commit details
    Browse the repository at this point in the history

  3. Fix broken nock config. Fix other broken tests

    Sarah Allen committed May 15, 2019
    Copy the full SHA
    ba02606 View commit details
    Browse the repository at this point in the history

  4. Fix missing update in package-lock for nock install

    Sarah Allen committed May 15, 2019
    Copy the full SHA
    a7ceafc View commit details
    Browse the repository at this point in the history

  5. Use a timeout to test initial subject load (#810) 

    Remove the spy on componentDidMount. Set a timeout instead, to wait for component state to update on mock subject load.
    @eatyourgreens
    eatyourgreens authored and Sarah Allen committed May 15, 2019
    Copy the full SHA
    2e40b95 View commit details
    Browse the repository at this point in the history

  6. Using async await with lifecycle methods. Update tests to use them

    Sarah Allen committed May 15, 2019
    Copy the full SHA
    a677348 View commit details
    Browse the repository at this point in the history

  7. Update LCV component and tests to use error handling in SubjectViewer… 

    …Store
    Sarah Allen committed May 15, 2019
    Copy the full SHA
    f80127d View commit details
    Browse the repository at this point in the history

  8. Remove unnecessary conditional checks. Remove only.

    Sarah Allen committed May 15, 2019
    Copy the full SHA
    a6a9615 View commit details
    Browse the repository at this point in the history

  9. Remove unnecessary url existence check

    Sarah Allen committed May 15, 2019
    Copy the full SHA
    c17a0bf View commit details
    Browse the repository at this point in the history

  10. Merge branch 'master' into lcv-tests

    @srallen
    srallen committed May 15, 2019
    Copy the full SHA
    a339f30 View commit details
    Browse the repository at this point in the history

  11. We set a default prop, so use that

    Sarah Allen committed May 15, 2019
    Copy the full SHA
    fc0ff07 View commit details
    Browse the repository at this point in the history

  12. Merge branch 'lcv-tests' of github.com:zooniverse/front-end-monorepo … 

    …into lcv-tests
    Sarah Allen committed May 15, 2019
    Copy the full SHA
    0cf7c49 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2019

  1. Merge branch 'master' into lcv-tests

    @srallen
    srallen committed May 16, 2019
    Copy the full SHA
    50cdca5 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2019

  1. Merge branch 'master' into lcv-tests

    @srallen
    srallen committed May 21, 2019
    Copy the full SHA
    5e3a13d View commit details
    Browse the repository at this point in the history

  2. Return the error handling. Remove unnecessary catches and conditionals

    Sarah Allen committed May 21, 2019
    Copy the full SHA
    ec5b8f6 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'lcv-tests' of github.com:zooniverse/front-end-monorepo … 

    …into lcv-tests
    Sarah Allen committed May 21, 2019
    Copy the full SHA
    79e7d29 View commit details
    Browse the repository at this point in the history

  4. Return the error from the store. Remove unnecessary return.

    Sarah Allen committed May 21, 2019
    Copy the full SHA
    526cfef View commit details
    Browse the repository at this point in the history

Commits on May 22, 2019

  1. Remove stray .only

    @eatyourgreens
    eatyourgreens committed May 22, 2019
    Copy the full SHA
    9b92bd4 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-Authored-By: Jim O'Donnell <jim@eatyourgreens.org.uk>
    @srallen @eatyourgreens
    srallen and eatyourgreens committed May 22, 2019
    Copy the full SHA
    e1bdede View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into lcv-tests

    @srallen
    srallen committed May 22, 2019
    Copy the full SHA
    282642d View commit details
    Browse the repository at this point in the history

  4. Remove unnecessary return

    Sarah Allen committed May 22, 2019
    Copy the full SHA
    8bce405 View commit details
    Browse the repository at this point in the history