Add IRC status commands EDITPORT and restrict DELPORT #1809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Possible fix (if wanted) for issue znc#1806 In "danger" of locking yourself out by removing your active port, this should not be possible (same as to HTTP) in my opinion. This will allow the modification of an active port instead.
Codecov Report
@@ Coverage Diff @@
## master #1809 +/- ##
==========================================
- Coverage 41.34% 41.17% -0.18%
==========================================
Files 122 122
Lines 27578 27624 +46
Branches 33 33
==========================================
- Hits 11402 11373 -29
- Misses 16151 16226 +75
Partials 25 25
Continue to review full report at Codecov.
|
|
Any tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix (if wanted) for issue #1806
In "danger" of locking yourself out by removing your active port, this should not be possible (same as to HTTP) in my opinion.
This will allow the modification of an active port instead.