Added DHE-RSA-CHACHA20-POLY1305 to default SSL Ciphers #1807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You've missed the "why?" part of the description |
| @@ -36,7 +36,10 @@ static CString ZNC_DefaultCipher() { | |||
| return "ECDHE-ECDSA-AES128-GCM-SHA256:ECDHE-RSA-AES128-GCM-SHA256:" | |||
| "ECDHE-ECDSA-AES256-GCM-SHA384:ECDHE-RSA-AES256-GCM-SHA384:" | |||
| "ECDHE-ECDSA-CHACHA20-POLY1305:ECDHE-RSA-CHACHA20-POLY1305:" | |||
| "DHE-RSA-AES128-GCM-SHA256:DHE-RSA-AES256-GCM-SHA384"; | |||
| "DHE-RSA-AES128-GCM-SHA256:DHE-RSA-AES256-GCM-SHA384:" | |||
There was a problem hiding this comment.
So this is not a copypaste from mozilla page anymore?
There was a problem hiding this comment.
Chacha20 is a good one, under certain aspects, better then AES too.
It has been implemented for ECDHE version too.
I checked a bit, but I find out no good reasons to exclude it.
It is still a "copy/paste", with just the add of Chacha20 for the DHE.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.