Allow capabilities to be handled after upstream IRC registration #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1735 +/- ##
==========================================
- Coverage 39.36% 39.35% -0.01%
==========================================
Files 123 123
Lines 28198 28199 +1
Branches 99 99
==========================================
- Hits 11100 11099 -1
- Misses 17049 17051 +2
Partials 49 49
Continue to review full report at Codecov.
|
I agree |
| } | ||
|
|
||
| SendNextCap(); |
There was a problem hiding this comment.
This will send CAP END as the response to CAP NEW
|
One more case: 2 CAP NEW in a row, so that second one was received before CAP ACK from our REQ from the first one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is perhaps the first part in being able to support cap-notify and capability 3.2 by extending the capability handling to occur after registration. I would like to add some automated testing, having some problems getting those passing (debugging setup with qt/python etc) so some delays with that.
The first change removes the
m_bAuthedcheck, and then the second change makes it so that subsequentCAP LSwon't trigger re-requesting already negotiated capabilities, otherwise the following would occur:Are there any other cases I am not thinking of? I am wondering about the interplay with some modules pausing capabilities after registration (perhaps PauseCap shouldn't do anything after registration?).