Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple hostmasks to autovoice #1652

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mjeveritt
Copy link

Porting the functionality of multiple hostmasks per user from the autoop module to autovoice.

@psychon
Copy link
Member

psychon commented Apr 19, 2019

How did you test this? Did you test this at all?

@mjeveritt
Copy link
Author

How did you test this? Did you test this at all?

It looks like my system isn't presently correctly set up for compilation, but I will investigate further...

Michael Everitt added 2 commits April 19, 2019 17:33
Signed-off-by: Michael Everitt <m.j.everitt@iee.org>
Signed-off-by: Michael Everitt <m.j.everitt@iee.org>
@mjeveritt
Copy link
Author

It looks like my system isn't presently correctly set up for compilation, but I will investigate further...

Someone forgot they needed to autogen.sh before configure/make .. all working fine now!

@DarthGandalf
Copy link
Member

Someone forgot they needed to autogen.sh before configure

Or you can use cmake

@DarthGandalf
Copy link
Member

It would be more maintainable if autoop and autovoice share the code, instead of "porting" features from one to another...

@mjeveritt
Copy link
Author

It would be more maintainable if autoop and autovoice share the code, instead of "porting" features from one to another...

Yes, I did think this .. what kind of module/program structure would you propose to do this best? Are there any more similar modules that would benefit from the same functions being made available "centrally"?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants