-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Happy Eyeballs. Fix IPv4/IPv6 in a better way. #1571
base: master
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1571 +/- ##
==========================================
- Coverage 37.45% 24.26% -13.2%
==========================================
Files 127 120 -7
Lines 31014 27789 -3225
Branches 93 60 -33
==========================================
- Hits 11617 6743 -4874
- Misses 19348 21022 +1674
+ Partials 49 24 -25
Continue to review full report at Codecov.
|
The problem with this approach: if server sends something immediately upon connect, that data is delivered to the temporary socket class, and it's lost. Looking how to solve this... |
This ticket is not a blocker for IPv6 support, all it means is that if a client gets a dual stack DNS result, it will prefer IPv6 by default on most systems. If IPv6 is broken on the path, then, yes, the connection will time out and ipv4 will be tried eventually. But that's not your fault, that's the fault of, the server, the ISPs between, or the user. Maybe just make it clear in the documentation that we don't have Happy Eyeballs yet and to either yolo with dual stack dns records, or, make a primary/dual, v4, v6 record seperately and give that to users. |
@Gunni I've replied on znc/znc-docker#19 That said, when I finish #1639, it'll be easy to fix ZNC->server side. Failure to implement this feature with current sockets we have caused me to start refactoring it. If only I had more time to finish #1639 faster... |
Without having looked at any code: Does |
AFAIR, no, it didn't help. |
Close #241