-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sentry instrumentation #15
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Devansh3712 <devanshamity@gmail.com> Reviewed-by: Kamoltat <ksirivad@redhat.com>
Signed-off-by: Devansh3712 <devanshamity@gmail.com> Reviewed-by: Kamoltat <ksirivad@redhat.com>
The original pulpito used routes like /:run/:job_id. While we prefer the more explicit routes, it'll be helpful if URLs are mostly backwards compatible. Signed-off-by: Zack Cerza <zack@redhat.com>
Signed-off-by: Med16-11 <singhmedhavi923@gmail.com>
Problem: CI doesn't trigger on pull requests Solution: rename deploy.yml to ci.yml and trigger CI on every PR. Also Added a Linter to CI. Signed-off-by: Kamoltat Sirivadhna <ksirivad@redhat.com>
Instead of using `formatDistanceToNow`, we came up with `timeSince` which basically utilizes Date.now() and used simple arithmetics to compute `started time` Signed-off-by: Med16-11 <singhmedhavi923@gmail.com>
pages/Job/index.js: fix job started time Reviewed-by: Kamoltat Sirivadhna <ksirivad@redhat.com>
Implement kill-run button Reviewed-by: Kamoltat Sirivadhna <ksirivad@redhat.com>
Revert "Implement kill-run button" Reviewed-by Kamoltat Sirivadhna <ksirivad@redhat.com> Reviewed-by Devansh Singh <devanshamity@gmail.com>
Signed-off-by: Med16-11 <singhmedhavi923@gmail.com>
pages/Runs/index.tsx: fixed date filter box alignment Reviewed-by: Kamoltat Sirivadhna <ksirivad@redhat.com>
Signed-off-by: Zack Cerza <zack@redhat.com>
This required updating several other dependencies, and removing @mui/styles Signed-off-by: Zack Cerza <zack@redhat.com>
npx @mui/codemod v5.0.0/jss-to-styled src Signed-off-by: Zack Cerza <zack@redhat.com>
It's deprecated. Signed-off-by: Zack Cerza <zack@redhat.com>
npm install --save-dev @typescript-eslint/parser \ @typescript-eslint/eslint-plugin eslint typescript Signed-off-by: Zack Cerza <zack@redhat.com>
Signed-off-by: Zack Cerza <zack@redhat.com>
Fixes errors mentioning "cannot be used as a JSX component." Signed-off-by: Zack Cerza <zack@redhat.com>
npm install @tanstack/react-query @tanstack/react-query-devtools npm uninstall react-query Signed-off-by: Zack Cerza <zack@redhat.com>
Fixes "require is not defined" Signed-off-by: Zack Cerza <zack@redhat.com>
Signed-off-by: Zack Cerza <zack@redhat.com>
The auto-reloads aren't great. Signed-off-by: Zack Cerza <zack@redhat.com>
Signed-off-by: Zack Cerza <zack@redhat.com>
Signed-off-by: Zack Cerza <zack@redhat.com>
This turned into a pretty major change. The breaking changes in the new DataGrid API necessitated a change in how we were storing and updating state. The reducers were dropped in favor of the use-query-params library. As a bonus, filtering, pagination, and deep links all work better than they did before. Signed-off-by: Zack Cerza <zack@redhat.com>
Signed-off-by: Vallari <val.agl002@gmail.com>
Other minor additions: 1. In nodes table, add links in 'name' column 2. Add 'hideFooter' prop in DataGrid component Signed-off-by: Vallari <val.agl002@gmail.com>
Signed-off-by: Vallari <val.agl002@gmail.com>
Signed-off-by: Vallari <val.agl002@gmail.com>
Signed-off-by: Vallari <val.agl002@gmail.com>
Signed-off-by: Vallari <val.agl002@gmail.com>
other minor fixes: - DataGrid: show boolean true/false symbols in black color - Drawer: "Nodes" route to /nodes?machine_type=smithi by default - NodeList: sort by name + thin machine_type col + length desc - StatsNodesJob: sort by name + display node's shortname - StatsNodesLock: sort by owner Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
- Node Page: use NodeList (instead of DataGrid) - useNodes(): remove params because machine_type filters should be on handled on client side - useNode(): return Node[] (instead of Node) so NodeList can be used Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
Done by adding 'pagingMode' prop to JobList component because Run page uses client side paging and Node Page needs server side paging Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
Dockerfile: Run in production mode Reviewed-by: Kamoltat Sirivadhna <ksirivad@redhat.com>
This truncates the longer strings to 200 chars. Signed-off-by: Zack Cerza <zack@redhat.com>
JobList: Hover on status col shows failure reason Reviewed-by: Kamoltat Sirivadhna <ksirivad@redhat.com>
We could add path-browserify as a dependency and have access to Node.js' path module, but that's 15kb and this is four lines. Signed-off-by: Zack Cerza <zack@redhat.com>
This is more helpful than linking directly to teuthology.log, which may not even exist yet. Signed-off-by: Zack Cerza <zack@redhat.com>
And change the text to "Log Archive" Signed-off-by: Zack Cerza <zack@redhat.com>
Job{,List}: Link to job archive directories Reviewed-by: Kamoltat Sirivadhna <ksirivad@redhat.com>
Github Authentication Reviewed-by: Kamoltat Sirivadhna <ksirivad@redhat.com>
Other minor changes: 1. set retry=1 for teuthologyAPI useSession query 2. disable login button when teuthology-api cannot be pinged Signed-off-by: Vallari Agrawal <val.agl002@gmail.com>
fix: default url for TEUTHOLOGY_API_SERVER Reviewed-by: Kamoltat Sirivadhna <ksirivad@redhat.com>
We were rendering a blank page on all routes if the teuthology-api endpoint wasn't configured. Signed-off-by: Zack Cerza <zack@redhat.com>
Signed-off-by: Zack Cerza <zack@redhat.com>
They're not implemented as React hooks, so let's not name them as if they are. Signed-off-by: Zack Cerza <zack@redhat.com>
Signed-off-by: Zack Cerza <zack@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.