Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix use-after-free's in IPIP probe module #815

Merged
merged 1 commit into from Mar 8, 2024
Merged

Fix use-after-free's in IPIP probe module #815

merged 1 commit into from Mar 8, 2024

Commits on Mar 8, 2024

  1. Fix use-after-free's in IPIP probe module 

    Fix two UaF's where memory in `args` was accessed through `c` pointer
after freeing `args`, silencing the respective compiler warnings on
Linux/GCC.  The UaFs are on error paths as part of parsing the command
line, and as such unreachable from malicious response packets.

While here, remove dead code after `log_fatal()`, avoid interpreting
percent chars in `ipip_usage_error`, replace a manual if/exit combo with
an assertion, and remove extra newlines in log strings.
    @droe
    droe committed Mar 8, 2024
    Copy the full SHA
    237cde7 View commit details
    Browse the repository at this point in the history