Double aesrand_getword() performance by using full 128 bits #801
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AES-128 PRNG construction produces 128 bits of pseudo-randomness per AES block encryption. Use the full 128 bits instead of throwing half of the bits away.
As long as aesrand is not used for any per-packet randomness, speeding up aesrand_getword() won't matter much, so the need for this change might seem arguable. With the old version of #798 that used aesrand_getword() for every packet, this change reduced the loss of send rate by about half.